Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When building an app, do not report remote package warnings #6700

Open
agu-z opened this issue May 1, 2024 · 0 comments
Open

When building an app, do not report remote package warnings #6700

agu-z opened this issue May 1, 2024 · 0 comments
Labels
loading Loading modules from files

Comments

@agu-z
Copy link
Sponsor Collaborator

agu-z commented May 1, 2024

We currently report warnings for all files we load. This means that the roc CLI will return a non-zero exit code when building an app that depends on a package with a warning. This can block the developer of the app from upgrading to a new version of the compiler, until the developer of the package fixes it.

When building an app, we should only report warnings that come from its source code or from packages that were loaded from a local file, instead of a URL.

@agu-z agu-z added the loading Loading modules from files label May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loading Loading modules from files
Projects
None yet
Development

No branches or pull requests

1 participant