Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support devices in roc-copy #655

Open
gavv opened this issue Dec 6, 2023 · 0 comments
Open

Support devices in roc-copy #655

gavv opened this issue Dec 6, 2023 · 0 comments
Labels
enhancement help wanted An important and awaited task but we have no human resources for it yet sound io Audio I/O

Comments

@gavv
Copy link
Member

gavv commented Dec 6, 2023

Problem

roc-copy tool copies samples from input to output, performing necessary conversions if necessary.

Currently roc-copy requires that both input and output should be files, and fails otherwise. It does it by checking has_clock() value, which is true for devices and false for files.

Solution

We can allow one of the input or output to be device (but not both, because roc-copy doesn't have clock drift compensation).

Code: https://github.com/roc-streaming/roc-toolkit/blob/develop/src/tools/roc_copy/main.cpp

Testing

Ensure that "copying" from microphone to file, and from file to speakers works fine.

E.g.:

roc-copy -vv -i pulse://default -o file:test.wav
roc-copy -vv -i file:test.wav -o pulse://default

Docs

Manual page should be updated: https://github.com/roc-streaming/roc-toolkit/blob/develop/docs/sphinx/manuals/roc_copy.rst

@gavv gavv added enhancement help wanted An important and awaited task but we have no human resources for it yet easy hacks The solution is expected to be straightforward even if you are new to the project sound io Audio I/O labels Dec 6, 2023
@gavv gavv added this to Help wanted in kanban board Dec 6, 2023
@gavv gavv moved this from Help wanted to Frontlog in kanban board Dec 6, 2023
@gavv gavv moved this from Frontlog to Help wanted in kanban board Dec 6, 2023
@gavv gavv removed the easy hacks The solution is expected to be straightforward even if you are new to the project label Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted An important and awaited task but we have no human resources for it yet sound io Audio I/O
Projects
kanban board
Help wanted
Development

No branches or pull requests

1 participant