Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link formatting issue in message popup #17222

Open
sryze opened this issue May 13, 2024 · 3 comments
Open

Link formatting issue in message popup #17222

sryze opened this issue May 13, 2024 · 3 comments
Labels
C-bug Category: bug

Comments

@sryze
Copy link

sryze commented May 13, 2024

Found a minor bug related to the rust-analyzer popup showing when a project doesn't have a Cargo.toml file. See the screenshot below:

vscode-rust-analyzer-popup-bug

It looks like the message is expected to be rendered as Markdown (the linkedProjects link) but it's showing as plain text instead.

rust-analyzer version: (eg. output of "rust-analyzer: Show RA Version" command, accessible in VSCode via Ctrl/⌘+Shift+P)
rust-analyzer version: 0.3.1958-standalone (5bf2f85 2024-05-09)

rustc version: (eg. output of rustc -V)
rustc 1.77.2 (25ef9e3d8 2024-04-09)

editor or extension: (eg. VSCode, Vim, Emacs, etc. For VSCode users, specify your extension version; for users of other editors, provide the distribution if applicable)
VS Code

relevant settings: (eg. client settings, or environment variables like CARGO, RUSTC, RUSTUP_HOME or CARGO_HOME)

repository link (if public, optional): (eg. rust-analyzer)

code snippet to reproduce:

// add your code here
@sryze sryze added the C-bug Category: bug label May 13, 2024
@sryze
Copy link
Author

sryze commented May 13, 2024

Seems related to #14366

@roife
Copy link
Contributor

roife commented May 15, 2024

Perhaps it's because VSC doesn't support rendering markdown in messages.

@Veykril
Copy link
Member

Veykril commented May 15, 2024

It does but that part is pasted verbatim from the extension code. We should remove the markdown there as we don't expect other clients to support markdown there currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

3 participants