Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track review activity #17

Open
pitaj opened this issue Jan 29, 2023 · 1 comment · May be fixed by #22
Open

Track review activity #17

pitaj opened this issue Jan 29, 2023 · 1 comment · May be fixed by #22

Comments

@pitaj
Copy link

pitaj commented Jan 29, 2023 •
edited

It's common for the last activity on a PR to be irrelevant:

  • comment from triage asking for status
  • author asking for status
  • rustbot informing about a merge conflict
  • author fixing a merge conflict

Ideally, we would track review activity:

  • exclude comments by the author
  • exclude rustbot comments
  • exclude comments by others with certain keywords like "triage", "status", "bump", etc
  • include all activity by the assigned reviewer
  • include code-review activity
  • exclude drafts

This obviously isn't possible with the basic Github filters available, but I think it would give us a much better idea of how long PRs are sitting without activity. Merge conflict notifications alone likely result in a de-facto upper limit to time-since-updated.
@pitaj
Copy link
Author

pitaj commented Jan 29, 2023 •
edited

I think a simple version of this can be achieved by tracking how long individual PRs have been in the current state (by tracking the state of each PR individually). This would allow us to see how long PRs are being left "waiting-on-review" or "waiting-on-ACP", etc.

@pitaj pitaj linked a pull request Jan 30, 2023 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Track review and author response latency pitaj/rustc-pr-tracking
1 participant
@pitaj