Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize values used more than once during the template function execution #243

Open
Gr8Gatsby opened this issue Apr 12, 2018 · 2 comments · May be fixed by #2300
Open

Memoize values used more than once during the template function execution #243

Gr8Gatsby opened this issue Apr 12, 2018 · 2 comments · May be fixed by #2300
Assignees
@jodarove
Labels
perf USER STORY

Comments

@Gr8Gatsby
Copy link

SOMA#255

Migrated issue

notes:

When accessing a getter, we can memoize the value produced by the getter and tied that value to the reactive objects accessed from within the getter, and only call the getter again if any of those reactive objects changes.

VUE implements some of this, and this will also prevent people doing premature optimizations when the getter is suppose to do complex operations.
@caridy caridy added the perf label Jan 11, 2019
@diervo diervo removed the gus-story label Feb 16, 2019
@caridy
Copy link
Contributor

caridy commented Sep 5, 2019 •
edited

If we are going to lift the restriction of mutations of non-decorated fields during rendering, we should make sure that we implement this, otherwise something like: <template>{cacheCounter}:{cacheCounter}</template> might output something like "1:2" instead of "1:1", without the memoization process.

@jodarove jodarove mentioned this issue Mar 26, 2021
Closed
@jodarove jodarove linked a pull request Apr 21, 2021 that will close this issue
Open
1 task
@uip-robot-zz
Copy link

This issue has been linked to a new work item: W-9479534

@nolanlawson nolanlawson mentioned this issue Jul 27, 2021
Open
@AllanOricil AllanOricil mentioned this issue Sep 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jodarove jodarove

Labels
perf USER STORY
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf: memoize values of cmp props when used multiple times in template salesforce/lwc
6 participants
@caridy @jodarove @diervo @pmdartus @Gr8Gatsby @uip-robot-zz