Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template function implicit stylesheets and freezetemplate code generation to @lwc/template-compiler #3931

Open
jmsjtu opened this issue Jan 9, 2024 · 0 comments · May be fixed by #4147

Comments

@jmsjtu
Copy link
Member

jmsjtu commented Jan 9, 2024

Currently, the template transformer generates code for implicit stylesheet imports, appending them to the template function, and freezing the template.

This logic is located in the @lwc/compiler packages but should really be moved to the @lwc/template-compiler.

We should do this as part of the final code generation to output the template function from @lwc/template-compiler.

@jmsjtu jmsjtu changed the title Move template function stylesheets and freezetemplate code generation from @lwc/compiler to @lwc/template-compiler Move template function implicity stylesheets and freezetemplate code generation from @lwc/compiler to @lwc/template-compiler Jan 9, 2024
@jmsjtu jmsjtu changed the title Move template function implicity stylesheets and freezetemplate code generation from @lwc/compiler to @lwc/template-compiler Move template function implicity stylesheets and freezetemplate code generation to @lwc/template-compiler Jan 9, 2024
@jmsjtu jmsjtu changed the title Move template function implicity stylesheets and freezetemplate code generation to @lwc/template-compiler Move template function implicit stylesheets and freezetemplate code generation to @lwc/template-compiler Jan 9, 2024
@jmsjtu jmsjtu added the refactor label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant