Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the minimum supported version of Node in engines #4150

Open
Tracked by #2964
nolanlawson opened this issue Apr 15, 2024 · 1 comment
Open
Tracked by #2964

Specify the minimum supported version of Node in engines #4150

nolanlawson opened this issue Apr 15, 2024 · 1 comment

Comments

@nolanlawson
Copy link
Contributor

Our engines is woefully out of date:

lwc/package.json

Lines 82 to 84 in 1dba707

"engines": {
"node": ">=10"
},

... and this is in our root package.json which isn't actually published to npm, so it doesn't do anything.

Instead, we should specify an engines like this across all our packages:

 "engines": { 
     "node": ">=18" 
 }, 

Arguably we should do this as a breaking change and just take this opportunity to bump our minimum supported Node version as well. Up to now, we have not really done a great job of communicating our minimum required version of Node, nor have we actually tested in multiple Node versions or bumped our major version when we dropped support for an older Node version. We should be more explicit about this.

See also: #4149

@wjhsf
Copy link
Contributor

wjhsf commented Apr 18, 2024

Running npm install global-jsdom jsdom lwc && node -r global-jsdom/register -e 'import("lwc").then(()=>console.log("success"))' only succeeds for v16+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants