Fixed #6 #23
Open
Fixed #6 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwiley4000
requested changes
Jul 14, 2017
benwiley4000
requested changes
Jul 14, 2017
| @@ -117,7 +117,7 @@ module.exports = function getPixels(url, type, cb) { | |||
| cb = type | |||
| type = '' | |||
| } | |||
| var ext = path.extname(url) | |||
| var ext = path.extname(url.toString().split('?')[0]) | |||
There was a problem hiding this comment.
It's not obvious to me what url.toString() would do if it's not already a String.
I checked, and it looks like path.extname(undefined) creates an error in Node's path module (at least the current version), while it returns an empty string for node-browserify (the browserify built-in which gets included in bundles). That said, the previous line was already relying on non-standard behavior.
What about:
var ext = url ? path.extname(url.split('?')[0]) : ''or:
var ext = typeof url === 'string' ? path.extname(url.split('?')[0]) : ''🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Fixes #6.