Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate input for get method (and others potentially) #38

Open
ismay opened this issue Apr 28, 2018 · 0 comments
Open

Validate input for get method (and others potentially) #38

ismay opened this issue Apr 28, 2018 · 0 comments

Comments

@ismay
Copy link

ismay commented Apr 28, 2018

The get() method does not throw an error when using floating point numbers for the array indices. I know that it's kind of obvious to not do this, but I ran into a bug that was quite difficult to trace because the ndarray was returning data that seemed valid, but was just sometimes wrong.

Throwing an error when floating point numbers are used to access data seems quite helpful. I assume that this goes for the set method as well (and maybe others).

spneshaei added a commit to spneshaei/ndarray that referenced this issue Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant