Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

mse needs updating (to friedman_mse?) #1162

Open
worthy7 opened this issue May 8, 2023 · 1 comment
Open

mse needs updating (to friedman_mse?) #1162

worthy7 opened this issue May 8, 2023 · 1 comment

Comments

@worthy7
Copy link

worthy7 commented May 8, 2023

def __init__(self, n_estimators=10, criterion='mse', max_depth=None,

It seems this function no longer works with the latest sklearn because mse no longer exists

@ldillard-avantus
Copy link

ldillard-avantus commented May 24, 2023

I'm having the same issue. I believe the correct criterion value would now be "squared_error". Note that it would also need to be changed in the predict function on line 438 of the same file.

I have patched this locally with just these two lines changed (197 and 438 of forest.py), and it works.

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants