Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PCL Profile 259 #5

Open
colincnash opened this issue May 26, 2015 · 2 comments
Open

Support PCL Profile 259 #5

colincnash opened this issue May 26, 2015 · 2 comments

Comments

@colincnash
Copy link

The reflection API's available in PCL profile 259 are different to those in the current version of LightMock (profile 136) and so the NuGet package cannot be added. (http://blogs.msdn.com/b/dotnet/archive/2012/08/28/evolving-the-reflection-api.aspx)

I have created a fork where I have updated LightMock to profile 259 but this will break it for existing users on profile 136. It would be great if we could find a way to support both profiles. I'd be happy to work on it if you have any ideas as I am finding LightMock combined with xUnit very useful for writing unit tests within a PCL which I can then execute in each platform.

@seesharper
Copy link
Owner

259 seems to be the profile with the highest amount of compatibility. What would we break if we changed it to 259?

@colincnash
Copy link
Author

It's just a couple of places where the reflection API's have changed. I'll send a pull request with my changes to support it although these probably need a review as they were written quite hastily. All the unit tests pass though.

It could probably do with some unit tests and possibly code changes around the async await functionality as well but I haven't had a chance to do these yet.

seesharper added a commit that referenced this issue Feb 7, 2017
seesharper added a commit that referenced this issue Feb 7, 2017
seesharper added a commit that referenced this issue Feb 7, 2017
seesharper added a commit that referenced this issue Feb 7, 2017
seesharper added a commit that referenced this issue Feb 7, 2017
seesharper added a commit that referenced this issue Feb 7, 2017
seesharper added a commit that referenced this issue Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants