Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robot should stop braking after motion stops #61

Open
andrewda opened this issue Oct 21, 2018 · 2 comments
Open

Robot should stop braking after motion stops #61

andrewda opened this issue Oct 21, 2018 · 2 comments
Labels
good first issue Good for newcomers priority/low

Comments

@andrewda
Copy link
Member

Currently the robot stops braking after 5 seconds of disable. We should have it stop braking after the robot stops moving in disabled (which we can see given the encoders' values).
@snowsignal
Copy link
Contributor

@andrewda, I can fix this.

@snowsignal
Copy link
Contributor

Would it make sense for me to spawn a thread that has a while loop running waiting for the encoders to indicate the robot has stopped?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers priority/low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewda @snowsignal