Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .NET 8 #12367

Closed
1 task done
martincostello opened this issue Feb 20, 2024 · 4 comments
Closed
1 task done

Add support for .NET 8 #12367

martincostello opened this issue Feb 20, 2024 · 4 comments

Comments

@martincostello
Copy link
Contributor

Is there an existing issue for this?

  • I have searched existing issues, it hasn't been reported yet

Use case description

Add support for the forthcoming .NET 8 support in AWS Lambda.

Runtime ID added to botocore.

Proposed solution (optional)

Add dotnet8 to the known list of AWS Lambda runtimes.

@martincostello
Copy link
Contributor Author

I guess this was resolved by serverless 4 beta, though it's a pity the team wouldn't take the trivial change to support for v3.

@protchenkos
Copy link

protchenkos commented Jun 5, 2024

Really weird... The team did v3 release adding support for java21 while skipping similar trivial change for dotnet8 😞
@martincostello if possible, could you reopen the issue and update name/add label to link it somehow to sls@3?

@martincostello
Copy link
Contributor Author

I could re-open it, but I have no ability to do anything to force a release.

The maintainers seem to have no interest in making this change for v3: #12368 (comment)

@slang25
Copy link
Contributor

slang25 commented Jun 5, 2024

I had the same feelings until I dug a bit deeper and saw that the java21 issue was not the same as dotnet8, in that it's not just a warning, there's also a line of code that specifically checks the java runtime version in order to invoke the lambda locally, and this check doesn't exist for dotnet.

e4dfebd#diff-a9b73bb11f3695264fd5588c011cff0aa048ae0bce44ddd7430f96b4c6e06033R269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants