Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Support combobox with many items #3698

Closed
2 tasks done
kenn opened this issue May 9, 2024 · 2 comments
Closed
2 tasks done

[feat]: Support combobox with many items #3698

kenn opened this issue May 9, 2024 · 2 comments

Comments

@kenn
Copy link

kenn commented May 9, 2024

Feature description

Combobox gets really slow when you have many items in it. In my case with 5,000 items, it takes full 2 seconds just to open the Popover / Drawer.

Headless UI v2.0 introduced new combobox using TanStack Virtual, which can handle 100,000+ items.

Would you consider incorporating the same idea?

Affected component/components

Combobox

Additional Context

Additional details here...

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues and PRs
@shadcn
Copy link
Collaborator

shadcn commented Jun 10, 2024

This issue has been automatically closed because it received no activity for a while. If you think it was closed by accident, please leave a comment. Thank you.

@shadcn shadcn closed this as completed Jun 10, 2024
@kenn
Copy link
Author

kenn commented Jun 11, 2024

It may be harder to implement, but I do think supporting a large list is essential for combobox — there's no better UI to deal with large-ish (~1MB in local storage) lists.

But it comes with additional complexity, so clearly it's a trade-off. I'm fine if this is out of scope for this library, but just would love to hear the decision clearly, not closed due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants