Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call fs.existsSync and then immediately call fs.lstatSync #232

Open
rcombs opened this issue Dec 7, 2016 · 0 comments
Open

Don't call fs.existsSync and then immediately call fs.lstatSync #232

rcombs opened this issue Dec 7, 2016 · 0 comments

Comments

@rcombs
Copy link

rcombs commented Dec 7, 2016

See: https://github.com/shama/gaze/blob/master/lib/gaze.js#L388
existsSync makes a stat syscall, and then lstatSync makes an lstat syscall. This is redundant and a waste of time. Just call fs.lstatSync and handle the exception if the file doesn't exist. This also solves your race condition between the two calls, which currently results in an exception being thrown out of the map call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant