Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(jsx-email): build process broken on Windows, fixes #194 #195

Merged
merged 1 commit into from May 9, 2024
Merged

fix(jsx-email): build process broken on Windows, fixes #194 #195

merged 1 commit into from May 9, 2024

Conversation

thomasdondorf
Copy link
Contributor

Component / Package Name:

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

If yes, please include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

resolves #194

Description

This pull fixed the currently broken build process on Windows.

shellscape
shellscape approved these changes May 8, 2024
View reviewed changes
Copy link
Owner

@shellscape shellscape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to find and fix this error, really appreciate it!

thanks!

@shellscape shellscape merged commit 28c4e39 into shellscape:main May 9, 2024
2 checks passed
@thomasdondorf
Copy link
Contributor Author

Thank you for this great package and for the fast merge+release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shellscape shellscape shellscape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken build process on Windows
2 participants
@thomasdondorf @shellscape