Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot process large JSON #4

Open
Relequestual opened this issue Jan 25, 2022 · 3 comments
Open

Cannot process large JSON #4

Relequestual opened this issue Jan 25, 2022 · 3 comments

Comments

@Relequestual
Copy link

Large JSON (Schema) does not seem to load.
Probably too big for putting in the URL

https://www.hl7.org/fhir/fhir.schema.json.zip
jviotti added a commit that referenced this issue Jan 29, 2022
@jviotti
Test FHIR JSON Schema definition
4c7634d 
See: #4
Fixes: #1
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti mentioned this issue Jan 29, 2022
Merged
jviotti added a commit that referenced this issue Jan 29, 2022
@jviotti
Do not store JSON documents as URL strings
e7a8e99 
Only works for small documents, otherwise the max URL size is hit and
the app breaks completely. I experimented with `localStorage`, but the
max quota there also imposes a too-strict limit on the document size.

Let's disable document saving for now.

See: #4
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@jviotti jviotti mentioned this issue Jan 29, 2022
Merged
@jviotti
Copy link
Member

jviotti commented Jan 29, 2022

@Relequestual The npm module is able to process the document just fine (takes around 1 sec on my M1 MacBook Pro). I disabled the URL-saving feature for now, as its definitely restricting (and so is localStorage apparently).

Even then, while the web app is technically capable of processing this document, the CodeMirror web editor chokes very badly, so I'll leave this issue open until that gets fixed.

Did you face the same issue on https://jsonschema.dev? Is there a better code editor I could use?

@MeastroZI
Copy link
Contributor

@jviotti I think it would be better to add file upload features for the schemas that are large in size, because I don't believe there is an web editor library that can handle big files like this one: https://www.hl7.org/fhir/fhir.schema.json.zip

@jviotti
Copy link
Member

jviotti commented Apr 16, 2024

True. I'll work on that at some point!

@MeastroZI MeastroZI mentioned this issue Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Relequestual @jviotti @MeastroZI