Request not available in signal

[mschoettle]

I am looking into a way to address #165 and noticed that the request is None in _thread_locals. This seems to be a bug (causing the extra work to retrieve the user in request_started). It also means that the user cannot be retrieved from the request in request_started.

It looks like the request is stored and immediately after deleted from the locals object in the middleware.

See:

django-easy-audit/easyaudit/middleware/easyaudit.py

Lines 49 to 56 in 0c98c56

	def __call__(self, request):
	_thread_locals.request = request # seems redundant w/process_request, but keeping in for now.
	if hasattr(self, 'process_request'):
	response = self.process_request(request)
	response = response or self.get_response(request)
	if hasattr(self, 'process_response'):
	response = self.process_response(request, response)
	return response

The order of execution is actually:

1. request_started signal triggered
2. EasyAuditMiddleware called

I saw in django-structlog that there are custom signals (foo = django.dispatch.Signal()) being used which are triggered from the middleware. This would allow for more fine-grained control.

So maybe something like the following could work:

def __call__(self, request):
    request_started_signal.send(sender=self.__class__, request=request)
    response = self.get_response(request)
    request_finished_signal.send(sender=self.__class__, request=request, response=response)

[steverecio]

@mschoettle did you figure this out? All my request events are suddenly not recording the User object anymore

[mschoettle]

No, haven't looked into this in a while but will need to soon.

Is it possible that you upgraded Django and then it stopped working? Which version of Django are you using?