Control exceptions silencing in DEBUG with a new setting

[dferens]

Hi,

Before making a PR, I'd like to know if you will support this idea or no.

Behavior of easyaudit is to silence any exception in signal handlers, which is what you need on prod:

django-easy-audit/easyaudit/signals/model_signals.py

Lines 128 to 129 in c78920b

	except Exception:
	pass

django-easy-audit/easyaudit/signals/model_signals.py

Lines 134 to 135 in c78920b

	except Exception:
	logger.exception('easy audit had a pre-save exception.')

But during development it's better to know that something isn't working in your signal handlers.

I propose to add a setting which will enable raising exceptions if DEBUG is True:

DJANGO_EASY_AUDIT_DEBUG_EXCEPTIONS=True  # False by default for backwards compat.

try:
    ...
except Exception:
    if settings.DEBUG and easyaudit.settings.DEBUG_EXCEPTIONS:
        raise
    else:
        pass

Let me know what you think.

Thanks!

[jheld]

Definitely, good idea

[Alex-Sichkar]

I've noticed that the pull request has already been merged. Are you certain that this will work as expected within transactions? The code re-raises exceptions from the crud_flow() callback, which is itself a transaction.on_commit() callback. In my case, it does not work as expected, exceptions are always thrown and cannot be silenced.