-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Number of operator changes behavior of it's input stream. #271
Comments
@ENvironmentSet Sounds like a bug in my opinion. Thanks for reporting |
@staltz Humm, this seems very complex, it related with termination of stream( |
@staltz I've made patch for this problem(one for PS. patch for fundamental problem breaks many tests since it changes some logic about terminating stream. |
@ENvironmentSet I'm of course curious to see the patch. Note however that if many tests break, it's probably not a suitable change to make, since tests reflect real-world use of xstream too. |
@staltz Indeed every patch should not destroy legacy code as much as it can(for backward compatibility). anyway, here is the fundamental problem(this might need some conversation to say it is real one): termination logic of stream is not solid. (it can be asynchronous but also can be synchronous!) |
Here, this is what i meant. |
Here is simple example with
take
operator.Yes, this makes sense. since
a
is hot observable.but, this doesn't make sense at all:
IMO, in this case, number of operator
take
should not be important to streama
.because operators should not change it's input stream. they are tend to modify input stream's output, not input stream.
anyway, I need other opinions. should we consider this as a bug? or something else(something like UB)?
The text was updated successfully, but these errors were encountered: