{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":458058,"defaultBranch":"7.1","name":"symfony","ownerLogin":"symfony","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-01-04T14:21:21.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/143937?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715960616.0","currentOid":""},"activityList":{"items":[{"before":"06a3da1dcb7adfc30a1c4f211bb103ab7b975d3e","after":"3509f038cc4ff03fae172f6bc3884cd52ce67257","ref":"refs/heads/5.4","pushedAt":"2024-05-17T21:28:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"minor #54985 [Security] Reviewed Polish translation of key 20 (thunderer)\n\nThis PR was merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[Security] Reviewed Polish translation of key 20\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | no\n| New feature? | no\n| Deprecations? | no\n| Issues | Fix #54956\n| License | MIT\n\nI'm a native Polish speaker.\n\nCommits\n-------\n\nf519a70695 [Security] reviewed Polish translation of key 20","shortMessageHtmlLink":"minor #54985 [Security] Reviewed Polish translation of key 20 (thunde…"}},{"before":"f21bd1d27f65fb87e461a069460eda453113e27d","after":"4bf657adab3ba36c29cf599a3b7eee50f525297f","ref":"refs/heads/7.1","pushedAt":"2024-05-17T15:48:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"fabpot","name":"Fabien Potencier","path":"/fabpot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47313?s=80&v=4"},"commit":{"message":"Bump Symfony version to 7.1.0","shortMessageHtmlLink":"Bump Symfony version to 7.1.0"}},{"before":"7c956d84af558313657e25b39bf098281206cd5d","after":"f21bd1d27f65fb87e461a069460eda453113e27d","ref":"refs/heads/7.1","pushedAt":"2024-05-17T15:43:13.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"fabpot","name":"Fabien Potencier","path":"/fabpot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47313?s=80&v=4"},"commit":{"message":"Merge pull request #54976 from fabpot/release-7.1.0-RC1\n\nreleased v7.1.0-RC1","shortMessageHtmlLink":"Merge pull request #54976 from fabpot/release-7.1.0-RC1"}},{"before":"232d6d00586fb8ef331408d8a040d7e4c7377ba2","after":"7c956d84af558313657e25b39bf098281206cd5d","ref":"refs/heads/7.1","pushedAt":"2024-05-17T15:06:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"xabbuh","name":"Christian Flothmann","path":"/xabbuh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1957048?s=80&v=4"},"commit":{"message":"minor #54974 [DoctrineBridge] fix bigint handling with DBAL 4 (xabbuh)\n\nThis PR was merged into the 7.1 branch.\n\nDiscussion\n----------\n\n[DoctrineBridge] fix bigint handling with DBAL 4\n\n| Q | A\n| ------------- | ---\n| Branch? | 7.1\n| Bug fix? | no\n| New feature? | no\n| Deprecations? | no\n| Issues |\n| License | MIT\n\nCommits\n-------\n\na289973660 fix bigint handling with DBAL 4","shortMessageHtmlLink":"minor #54974 [DoctrineBridge] fix bigint handling with DBAL 4 (xabbuh)"}},{"before":"4e01371ca98b8ee0c4dbb5e218ee5ff247157e48","after":"232d6d00586fb8ef331408d8a040d7e4c7377ba2","ref":"refs/heads/7.1","pushedAt":"2024-05-17T14:46:34.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"xabbuh","name":"Christian Flothmann","path":"/xabbuh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1957048?s=80&v=4"},"commit":{"message":"Merge branch '7.0' into 7.1\n\n* 7.0:\n fix merge\n fix merge\n fix merge","shortMessageHtmlLink":"Merge branch '7.0' into 7.1"}},{"before":"142c4be160f371e36e6fc4f9be5d6c97e56d5542","after":"0e1883ecee9efc13cb2e260c57213b93fb60dcb6","ref":"refs/heads/7.0","pushedAt":"2024-05-17T14:46:09.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"xabbuh","name":"Christian Flothmann","path":"/xabbuh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1957048?s=80&v=4"},"commit":{"message":"Merge branch '6.4' into 7.0\n\n* 6.4:\n fix merge\n fix merge\n fix merge","shortMessageHtmlLink":"Merge branch '6.4' into 7.0"}},{"before":"01d48d84867f21da3b4f78b9f62977335e50c828","after":"f94a57d63afd63c07d2b60c618d56facbd53cfa8","ref":"refs/heads/6.4","pushedAt":"2024-05-17T14:43:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"xabbuh","name":"Christian Flothmann","path":"/xabbuh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1957048?s=80&v=4"},"commit":{"message":"fix merge","shortMessageHtmlLink":"fix merge"}},{"before":"af4b4044ba9427fb71b7fbf447b6e0affef6370f","after":"01d48d84867f21da3b4f78b9f62977335e50c828","ref":"refs/heads/6.4","pushedAt":"2024-05-17T14:37:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"xabbuh","name":"Christian Flothmann","path":"/xabbuh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1957048?s=80&v=4"},"commit":{"message":"fix merge","shortMessageHtmlLink":"fix merge"}},{"before":"7adba2889ddbcc731e6b5b7bb71df65f651dbfb2","after":"af4b4044ba9427fb71b7fbf447b6e0affef6370f","ref":"refs/heads/6.4","pushedAt":"2024-05-17T14:34:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"xabbuh","name":"Christian Flothmann","path":"/xabbuh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1957048?s=80&v=4"},"commit":{"message":"fix merge","shortMessageHtmlLink":"fix merge"}},{"before":"6284bb52ac3624747a858b69fcfe308c8cf0fcdb","after":"06a3da1dcb7adfc30a1c4f211bb103ab7b975d3e","ref":"refs/heads/5.4","pushedAt":"2024-05-17T14:23:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"minor #54972 Reviewing translations for Japanese. (k-sahara)\n\nThis PR was squashed before being merged into the 5.4 branch.\n\nDiscussion\n----------\n\nReviewing translations for Japanese.\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | no\n| New feature? | no\n| Deprecations? | no\n| Issues | Fix #53370\n| License | MIT\n\n\n\nCommits\n-------\n\n27b5030f34 Reviewing translations for Japanese.","shortMessageHtmlLink":"minor #54972 Reviewing translations for Japanese. (k-sahara)"}},{"before":"c58c599b9e6cd61c8866271fbe1453cb39fa34b5","after":"4e01371ca98b8ee0c4dbb5e218ee5ff247157e48","ref":"refs/heads/7.1","pushedAt":"2024-05-17T14:21:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"bug #54970 [DependencyInjection] Process PHP configs using the ContainerConfigurator (MatTheCat)\n\nThis PR was merged into the 7.1 branch.\n\nDiscussion\n----------\n\n[DependencyInjection] Process PHP configs using the ContainerConfigurator\n\n| Q | A\n| ------------- | ---\n| Branch? | 7.1\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues | Fix #54852\n| License | MIT\n\nSince #52843, `ContainerConfigurator::extension` is not called anymore which means `ParamConfigurator`s are no longer processed and converted to strings, and make nodes validation fail: e.g. `framework.secret` would receive an `EnvConfigurator` and throw because it is not a scalar.\n\nCommits\n-------\n\ne6dc6be2c0 [DependencyInjection] Process PHP configs using the ContainerConfigurator","shortMessageHtmlLink":"bug #54970 [DependencyInjection] Process PHP configs using the Contai…"}},{"before":"bb916147f3ff10599547a15b3c9fbe72d95cf592","after":"c58c599b9e6cd61c8866271fbe1453cb39fa34b5","ref":"refs/heads/7.1","pushedAt":"2024-05-17T10:55:23.000Z","pushType":"push","commitsCount":34,"pusher":{"login":"fabpot","name":"Fabien Potencier","path":"/fabpot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47313?s=80&v=4"},"commit":{"message":"Merge branch '7.0' into 7.1\n\n* 7.0:\n [Serializer] Improve exception message in UnwrappingDenormalizer\n [PropertyInfo] Update DoctrineExtractor for new DBAL 4 BIGINT type\n Update security.nl.xlf\n [Validator] IBAN Check digits should always between 2 and 98\n [Security] Populate translations for trans-unit 20\n add missing plural translation messages\n filter out empty HTTP header parts\n [String] Fix folded in compat mode\n Remove calls to `getMockForAbstractClass()`\n [ErrorHandler] Do not call xdebug_get_function_stack() with xdebug >= 3.0 when not in develop mode\n [Serializer] Fix type for missing property\n add test for JSON response with null as content\n [Filesystem] Fix dumpFile `stat failed` error hitting custom handler\n Return false in isTtySupported() when open_basedir restrictions prevent access to /dev/tty.\n Remove calls to `TestCase::iniSet()` and calls to deprecated methods of `MockBuilder`\n [PhpUnitBridge] Fix `DeprecationErrorHandler` with PhpUnit 10","shortMessageHtmlLink":"Merge branch '7.0' into 7.1"}},{"before":"c96cca50dc270451e4e4a4c5c4489f39eb38cf91","after":"142c4be160f371e36e6fc4f9be5d6c97e56d5542","ref":"refs/heads/7.0","pushedAt":"2024-05-17T10:51:20.000Z","pushType":"push","commitsCount":33,"pusher":{"login":"fabpot","name":"Fabien Potencier","path":"/fabpot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47313?s=80&v=4"},"commit":{"message":"Merge branch '6.4' into 7.0\n\n* 6.4:\n [Serializer] Improve exception message in UnwrappingDenormalizer\n [PropertyInfo] Update DoctrineExtractor for new DBAL 4 BIGINT type\n Update security.nl.xlf\n [Validator] IBAN Check digits should always between 2 and 98\n [Security] Populate translations for trans-unit 20\n add missing plural translation messages\n filter out empty HTTP header parts\n [String] Fix folded in compat mode\n Remove calls to `getMockForAbstractClass()`\n [ErrorHandler] Do not call xdebug_get_function_stack() with xdebug >= 3.0 when not in develop mode\n [Serializer] Fix type for missing property\n add test for JSON response with null as content\n [Filesystem] Fix dumpFile `stat failed` error hitting custom handler\n Return false in isTtySupported() when open_basedir restrictions prevent access to /dev/tty.\n Remove calls to `TestCase::iniSet()` and calls to deprecated methods of `MockBuilder`\n [PhpUnitBridge] Fix `DeprecationErrorHandler` with PhpUnit 10","shortMessageHtmlLink":"Merge branch '6.4' into 7.0"}},{"before":"e4bd5934d8daf6a496bb7d2a8da9451080d0b8e0","after":"7adba2889ddbcc731e6b5b7bb71df65f651dbfb2","ref":"refs/heads/6.4","pushedAt":"2024-05-17T10:50:48.000Z","pushType":"push","commitsCount":28,"pusher":{"login":"fabpot","name":"Fabien Potencier","path":"/fabpot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47313?s=80&v=4"},"commit":{"message":"Merge branch '5.4' into 6.4\n\n* 5.4:\n [PropertyInfo] Update DoctrineExtractor for new DBAL 4 BIGINT type\n Update security.nl.xlf\n [Validator] IBAN Check digits should always between 2 and 98\n [Security] Populate translations for trans-unit 20\n add missing plural translation messages\n filter out empty HTTP header parts\n [String] Fix folded in compat mode\n Remove calls to `getMockForAbstractClass()`\n [ErrorHandler] Do not call xdebug_get_function_stack() with xdebug >= 3.0 when not in develop mode\n [Serializer] Fix type for missing property\n add test for JSON response with null as content\n [Filesystem] Fix dumpFile `stat failed` error hitting custom handler\n Remove calls to `TestCase::iniSet()` and calls to deprecated methods of `MockBuilder`\n [PhpUnitBridge] Fix `DeprecationErrorHandler` with PhpUnit 10","shortMessageHtmlLink":"Merge branch '5.4' into 6.4"}},{"before":"b49df796764fd913f03566ace993d0f55d5bb88c","after":"e4bd5934d8daf6a496bb7d2a8da9451080d0b8e0","ref":"refs/heads/6.4","pushedAt":"2024-05-17T09:01:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fabpot","name":"Fabien Potencier","path":"/fabpot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47313?s=80&v=4"},"commit":{"message":"bug #49186 [Serializer] Improve exception message in UnwrappingDenormalizer (andersonamuller)\n\nThis PR was submitted for the 7.1 branch but it was squashed and merged into the 6.4 branch instead.\n\nDiscussion\n----------\n\n[Serializer] Improve exception message in UnwrappingDenormalizer\n\n| Q | A\n| ------------- | ---\n| Branch? | 6.3\n| Bug fix? | no\n| New feature? | no\n| Deprecations? | no\n| Tickets | -\n| License | MIT\n| Doc PR | -\n\nThe current code expects the path to be replaced in the message, but probably it was forgotten.\n\nCommits\n-------\n\n3c96bfb0da [Serializer] Improve exception message in UnwrappingDenormalizer","shortMessageHtmlLink":"bug #49186 [Serializer] Improve exception message in UnwrappingDenorm…"}},{"before":"69d10fee2c41f0f1381e6e0a6258676c6c8cd791","after":"6284bb52ac3624747a858b69fcfe308c8cf0fcdb","ref":"refs/heads/5.4","pushedAt":"2024-05-17T08:54:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fabpot","name":"Fabien Potencier","path":"/fabpot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47313?s=80&v=4"},"commit":{"message":"minor #54962 [Security] Reviewed translation for Dutch (nl) (stephanvierkant)\n\nThis PR was merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[Security] Reviewed translation for Dutch (nl)\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | no\n| New feature? | no\n| Deprecations? | no\n| Issues | Fix #54949\n| License | MIT\n\n\n\nCommits\n-------\n\n82a1f0b8c6 Update security.nl.xlf","shortMessageHtmlLink":"minor #54962 [Security] Reviewed translation for Dutch (nl) (stephanv…"}},{"before":"a03ad0e1f883d8b9c5afaba30ce31516f905a48c","after":"69d10fee2c41f0f1381e6e0a6258676c6c8cd791","ref":"refs/heads/5.4","pushedAt":"2024-05-17T08:53:35.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fabpot","name":"Fabien Potencier","path":"/fabpot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/47313?s=80&v=4"},"commit":{"message":"bug #54694 [PropertyInfo] Update DoctrineExtractor for new DBAL 4 BIGINT type (llupa)\n\nThis PR was squashed before being merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[PropertyInfo] Update DoctrineExtractor for new DBAL 4 BIGINT type\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | yes\n| New feature? | not sure\n| Deprecations? | no\n| Issues | Fix #54418\n| License | MIT\n\n## Additional Considerations\n\nThis issue looks pretty straight forward, but it has had me running in circles not being sure how to exactly interpret it. The new return type to make it work with DBAL 4 is _fine_, but it is neither an intersection nor a union type, which **will** cause trouble for other libs if they do not explicitly check each.\n\nThere is not easy way to get which DBAL version is the extractor is running against, so trying to optimize the flow is _tricky_. I am opening this PR to have a starting point in the hopes that maintainers of this package have more historical context than me.\n\nI have tried to document as much as possible about this in the issue linked above. 🍻\n\nCommits\n-------\n\n92e54acf7c [PropertyInfo] Update DoctrineExtractor for new DBAL 4 BIGINT type","shortMessageHtmlLink":"bug #54694 [PropertyInfo] Update DoctrineExtractor for new DBAL 4 BIG…"}},{"before":"0da4e3a233d236b01c00e9d8a2fac78cdb4cd2a0","after":"bb916147f3ff10599547a15b3c9fbe72d95cf592","ref":"refs/heads/7.1","pushedAt":"2024-05-17T07:37:57.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"xabbuh","name":"Christian Flothmann","path":"/xabbuh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1957048?s=80&v=4"},"commit":{"message":"bug #54851 [Serializer] Fixed \"Warning: Attempt to read property \"value\" on string\" (michaljusiega, xabbuh)\n\nThis PR was merged into the 7.1 branch.\n\nDiscussion\n----------\n\n[Serializer] Fixed \"Warning: Attempt to read property \"value\" on string\"\n\n| Q | A\n| ------------- | ---\n| Branch? | 7.1 (7.1.0-BETA1)\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues | Fixed regresion of https://github.com/symfony/symfony/pull/53160\n| License | MIT\n\nHi! I've updated my project to `7.1.0-BETA1` and I found an error.\n\nAfter update I got: `Warning: Attempt to read property \"value\" on string` in `vendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:748` because in `733 line` the enum-case of value `TypeIdentifier` has been already readed.\n\n![obraz](https://github.com/symfony/symfony/assets/16488888/5227ac76-0fb0-4b00-ab68-2394ab41d7b7)\n\nQuite not sure if tests are possible here.\n\nCommits\n-------\n\n90251c9361 add test\n4b3dcf1ca6 Fixed \"Warning: Attempt to read property \"value\" on string\"","shortMessageHtmlLink":"bug #54851 [Serializer] Fixed \"Warning: Attempt to read property \"val…"}},{"before":"0d6452bcdb0bbf125ebac08a795017f6a03db9ed","after":"0da4e3a233d236b01c00e9d8a2fac78cdb4cd2a0","ref":"refs/heads/7.1","pushedAt":"2024-05-17T07:26:26.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"minor #54960 [Serializer] add missing deprecation contracts dependency (xabbuh)\n\nThis PR was merged into the 7.1 branch.\n\nDiscussion\n----------\n\n[Serializer] add missing deprecation contracts dependency\n\n| Q | A\n| ------------- | ---\n| Branch? | 7.1\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues |\n| License | MIT\n\nrequired since #54643\n\nCommits\n-------\n\na912c49820 add missing deprecation contracts dependency","shortMessageHtmlLink":"minor #54960 [Serializer] add missing deprecation contracts dependenc…"}},{"before":"e86406fd20a931226a8166d9f43f97a4ec19c29f","after":"a03ad0e1f883d8b9c5afaba30ce31516f905a48c","ref":"refs/heads/5.4","pushedAt":"2024-05-16T15:05:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"bug #54913 [Serializer] Fix CurrentType for missing property (ElisDN)\n\nThis PR was merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[Serializer] Fix CurrentType for missing property\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues |\n| License | MIT\n\nIf requested data does not contain any property:\n\n```php\nclass A {\n function __construct(string $a) {}\n}\n\ntry {\n $a = $serializer->deserialize('{}', A::class, 'json');\n} catch (NotNormalizableValueException $e) {\n var_dump($e->getMessage()); // \"Failed to create object because class misses the 'a' property.\"\n var_dump($e->getPath()); // \"a\"\n var_dump($e->getExpectedTypes()); // [\"string\"]\n var_dump($e->getCurrentType()); // \"array\"\n}\n```\n\nthen `getCurrentType` returns incorrect `\"array\"` value instead of expected `\"null\"` value.\n\nCommits\n-------\n\n5de8771334 [Serializer] Fix type for missing property","shortMessageHtmlLink":"bug #54913 [Serializer] Fix CurrentType for missing property (ElisDN)"}},{"before":"aa493f2be65e1aa749bc1c3a3c9f50bed1f207ad","after":"0d6452bcdb0bbf125ebac08a795017f6a03db9ed","ref":"refs/heads/7.1","pushedAt":"2024-05-16T14:44:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"feature #54941 Les-Tilleuls.coop is sponsoring Symfony 7.1, thanks to them! \\o/ (nicolas-grekas)\n\nThis PR was merged into the 7.1 branch.\n\nDiscussion\n----------\n\nLes-Tilleuls.coop is sponsoring Symfony 7.1, thanks to them! \\o/\n\n| Q | A\n| ------------- | ---\n| Branch? | 7.1\n| Bug fix? | no\n| New feature? | no\n| Deprecations? | no\n| Issues | -\n| License | MIT\n\nCommits\n-------\n\n5d02ba3a00 Les-Tilleuls.coop is sponsoring Symfony 7.1, thanks to them! \\o/","shortMessageHtmlLink":"feature #54941 Les-Tilleuls.coop is sponsoring Symfony 7.1, thanks to…"}},{"before":"f68a8dfacec1cffd33a567679748dc43b5ee6700","after":"e86406fd20a931226a8166d9f43f97a4ec19c29f","ref":"refs/heads/5.4","pushedAt":"2024-05-16T14:44:24.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"bug #54797 [PhpUnitBridge] Fix `DeprecationErrorHandler` with PhpUnit 10 (HypeMC)\n\nThis PR was merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[PhpUnitBridge] Fix `DeprecationErrorHandler` with PhpUnit 10\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues | -\n| License | MIT\n\nCurrently, when using the `DeprecationErrorHandler` with PhpUnit 10, warnings are ignored, e.g.:\n\n```php\nuse PHPUnit\\Framework\\TestCase;\n\nclass ExampleTest extends TestCase\n{\n public function testFindUniqueTournamentMonths(): void\n {\n $someVar = $nonExistentVar; // $nonExistentVar doesn't exist\n\n self::assertSame(1, 1);\n }\n}\n```\n\n```\nPHPUnit 10.5.20 by Sebastian Bergmann and contributors.\n\nRuntime: PHP 8.3.4\nConfiguration: /app/phpunit.xml.dist\n\nPHP Warning: Undefined variable $nonExistentVar in /app/tests/ExampleTest.php on line 11\n\nWarning: Undefined variable $nonExistentVar in /app/tests/ExampleTest.php on line 11\n. 1 / 1 (100%)\n\nTime: 00:00.010, Memory: 19.22 MB\n\nOK (1 test, 1 assertion)\n```\n\nThe reason I added the closure was to return `true`, otherwise, the errors would still be displayed, e.g.:\n\n```diff\n if ('PHPUnit\\Util\\ErrorHandler::handleError' === $eh) {\n return $eh;\n+ } elseif (ErrorHandler::class === $eh) {\n+ return ErrorHandler::instance();\n }\n```\n\n```\nPHPUnit 10.5.20 by Sebastian Bergmann and contributors.\n\nRuntime: PHP 8.3.4\nConfiguration: /app/phpunit.xml.dist\n\nPHP Warning: Undefined variable $nonExistentVar in /app/tests/ExampleTest.php on line 11\n\nWarning: Undefined variable $nonExistentVar in /app/tests/ExampleTest.php on line 11\nW 1 / 1 (100%)\n\nTime: 00:00.009, Memory: 19.22 MB\n\nOK, but there were issues!\nTests: 1, Assertions: 1, Warnings: 1.\n```\n\nNow, it works as expected:\n\n```\nPHPUnit 10.5.20 by Sebastian Bergmann and contributors.\n\nRuntime: PHP 8.3.4\nConfiguration: /app/phpunit.xml.dist\n\nW 1 / 1 (100%)\n\nTime: 00:00.008, Memory: 19.22 MB\n\nOK, but there were issues!\nTests: 1, Assertions: 1, Warnings: 1.\n```\n\nCommits\n-------\n\nca9f2a521a [PhpUnitBridge] Fix `DeprecationErrorHandler` with PhpUnit 10","shortMessageHtmlLink":"bug #54797 [PhpUnitBridge] Fix DeprecationErrorHandler with PhpUnit…"}},{"before":"a8a31e6280180d477a818338419b54581a2c69d2","after":"f68a8dfacec1cffd33a567679748dc43b5ee6700","ref":"refs/heads/5.4","pushedAt":"2024-05-16T14:40:30.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"bug #54878 [Filesystem] Fix dumpFile `stat failed` error hitting custom handler (acoulton)\n\nThis PR was merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[Filesystem] Fix dumpFile `stat failed` error hitting custom handler\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues | See below\n| License | MIT\n\nSince #54471, dumpFile will trigger a `fileperms(): stat failed` error when writing to a filename that does not yet exist. This was silenced from PHP's default handler with the `@` operator.\n\nHowever, the error is still passed to any custom handler that the application has registered, and can therefore cause exceptions or spurious logging depending on the implementation of the handler.\n\nThe better solution, which is consistent with all other calls to native functions in this class, would be to use `self::box` to catch and ignore the potential error so that it never leaks outside this class.\n\nCommits\n-------\n\n247182a7c0 [Filesystem] Fix dumpFile `stat failed` error hitting custom handler","shortMessageHtmlLink":"bug #54878 [Filesystem] Fix dumpFile stat failed error hitting cust…"}},{"before":"03465f2d7ceb025c476045b639788986ae98b4f1","after":"a8a31e6280180d477a818338419b54581a2c69d2","ref":"refs/heads/5.4","pushedAt":"2024-05-16T14:24:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"bug #54924 [Validator] IBAN Check digits should always between 2 and 98 (karstennilsen)\n\nThis PR was squashed before being merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[Validator] IBAN Check digits should always between 2 and 98\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | yes/no\n| New feature? | no\n| Deprecations? | no\n| Issues | No existing\n| License | MIT\n\nA ECBS document (https://www.ecbs.org/Download/EBS204_V3.PDF) replicates part of the ISO/IEC 7064:2003 standard as a method for generating check digits in the range 02 to 98.\n\nBesides this I have a production database of 160K valid IBANs. All of them have a check digit between 02 and 98.\n\nExample of invalid IBANs, which before were valid, are NL01INGB0001393698 and NL01RABO0331811235. You can check them at iban.com to verify they are indeed invalid.\n\nCommits\n-------\n\n16fc595609 [Validator] IBAN Check digits should always between 2 and 98","shortMessageHtmlLink":"bug #54924 [Validator] IBAN Check digits should always between 2 and …"}},{"before":"6049793d1ecacaed9ee96379bf31f3966049215b","after":"03465f2d7ceb025c476045b639788986ae98b4f1","ref":"refs/heads/5.4","pushedAt":"2024-05-16T09:15:02.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"minor #54934 [Security] add missing plural translation messages (xabbuh, nicolas-grekas)\n\nThis PR was merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[Security] add missing plural translation messages\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues | Fix #54914\n| License | MIT\n\nCommits\n-------\n\nbfa0b1b178 [Security] Populate translations for trans-unit 20\n0c511789d1 add missing plural translation messages","shortMessageHtmlLink":"minor #54934 [Security] add missing plural translation messages (xabb…"}},{"before":"ad68f738d00388d2a8c691b92d43704fa4fcec91","after":"aa493f2be65e1aa749bc1c3a3c9f50bed1f207ad","ref":"refs/heads/7.1","pushedAt":"2024-05-16T06:36:42.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"minor #54807 [TwigBridge][WebProfilerBundle] Require Twig 3.10 (derrabus)\n\nThis PR was merged into the 7.1 branch.\n\nDiscussion\n----------\n\n[TwigBridge][WebProfilerBundle] Require Twig 3.10\n\n| Q | A\n| ------------- | ---\n| Branch? | 7.1\n| Bug fix? | no\n| New feature? | no\n| Deprecations? | no\n| Issues | N/A\n| License | MIT\n\nRequiring a more recent version of Twig allows us to drop some compat code.\n\nCommits\n-------\n\nd8fd6097b7 [TwigBridge][WebProfilerBundle] Require Twig 3.10","shortMessageHtmlLink":"minor #54807 [TwigBridge][WebProfilerBundle] Require Twig 3.10 (derra…"}},{"before":"1b258e180d244c06d3f26e90da990f90a5977e64","after":"6049793d1ecacaed9ee96379bf31f3966049215b","ref":"refs/heads/5.4","pushedAt":"2024-05-15T16:31:15.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"bug #54919 [ErrorHandler] Do not call xdebug_get_function_stack() with xdebug >= 3.0 when not in develop mode (fmata)\n\nThis PR was merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[ErrorHandler] Do not call xdebug_get_function_stack() with xdebug >= 3.0 when not in develop mode\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues | Fix #40677\n| License | MIT\n\nThe PR #40787 was rejected because of env var handling in xdebug_mode. https://github.com/xdebug/xdebug/pull/737 allow us to get xdebug_mode in all cases so I think we can merge this PR safely.\n\nTested on my setup successfully, I have no more warning.\n\nThanks `@ralphschindler` :)\n\nCommits\n-------\n\na8114fee46 [ErrorHandler] Do not call xdebug_get_function_stack() with xdebug >= 3.0 when not in develop mode","shortMessageHtmlLink":"bug #54919 [ErrorHandler] Do not call xdebug_get_function_stack() wit…"}},{"before":"c656ad1ebc52ba16eb924940fe000bb9234c0118","after":"1b258e180d244c06d3f26e90da990f90a5977e64","ref":"refs/heads/5.4","pushedAt":"2024-05-15T14:55:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"bug #54910 [HttpFoundation]  filter out empty HTTP header parts (xabbuh)\n\nThis PR was merged into the 5.4 branch.\n\nDiscussion\n----------\n\n[HttpFoundation]  filter out empty HTTP header parts\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues | Fix #54868\n| License | MIT\n\nCommits\n-------\n\n7d6d8cd97f filter out empty HTTP header parts","shortMessageHtmlLink":"bug #54910 [HttpFoundation]  filter out empty HTTP header parts (xabbuh)"}},{"before":"ac30c7e6bc4f0bab77ad01f95164283fbca94857","after":"c656ad1ebc52ba16eb924940fe000bb9234c0118","ref":"refs/heads/5.4","pushedAt":"2024-05-15T11:16:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"nicolas-grekas","name":"Nicolas Grekas","path":"/nicolas-grekas","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/243674?s=80&v=4"},"commit":{"message":"bug #54888 [String] Fix folded in compat mode (smnandre)\n\nThis PR was submitted for the 6.4 branch but it was squashed and merged into the 5.4 branch instead.\n\nDiscussion\n----------\n\n[String] Fix folded in compat mode\n\n| Q | A\n| ------------- | ---\n| Branch? | 5.4\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues | -\n| License | MIT\n\n(Spotted by PHPStorm)\n\nBoth those lines of code were setting `$str->string` value, the second line cancelling any effect of the first.\n\n```php\n$str->string = normalizer_normalize($str->string, $compat ? \\Normalizer::NFKC : \\Normalizer::NFC);\n$str->string = mb_strtolower(str_replace(self::FOLD_FROM, self::FOLD_TO, $this->string), 'UTF-8');\n```\n\nDid not know if i had to add tests, as the `$compat` argument is not really defined in the interface... and seems unused in the codebase 🤷‍♂️\n\n(It also took me a bit of time to realize the `dataProvider` problem 😮‍💨 )\n\nCommits\n-------\n\n37e98c70d2 [String] Fix folded in compat mode","shortMessageHtmlLink":"bug #54888 [String] Fix folded in compat mode (smnandre)"}},{"before":"744e54bf1f71821f48252a911b13e95b99400bf0","after":"ad68f738d00388d2a8c691b92d43704fa4fcec91","ref":"refs/heads/7.1","pushedAt":"2024-05-15T08:46:29.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"xabbuh","name":"Christian Flothmann","path":"/xabbuh","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1957048?s=80&v=4"},"commit":{"message":"bug #54925 [VarDumper]  adapt namespace changes for new DOM extension classes (xabbuh)\n\nThis PR was merged into the 7.1 branch.\n\nDiscussion\n----------\n\n[VarDumper]  adapt namespace changes for new DOM extension classes\n\n| Q | A\n| ------------- | ---\n| Branch? | 7.1\n| Bug fix? | yes\n| New feature? | no\n| Deprecations? | no\n| Issues |\n| License | MIT\n\nrelated to php/php-src#14171\n\nCommits\n-------\n\n7e25a467c2 adapt namespace changes for new DOM extension classes","shortMessageHtmlLink":"bug #54925 [VarDumper]  adapt namespace changes for new DOM extension…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAETU5xQQA","startCursor":null,"endCursor":null}},"title":"Activity · symfony/symfony"}