[Bug]: Error: concurrency must be a number greater than 0

[adamreisnz]

Version

v3.15.8

Platform

NodeJS

What happened?

It appears there is an unexpected breaking change somewhere between versions 3.2.2 and 3.15.8, where the concurrency of workers no longer works via the syntax:

     const worker = new Worker(type, async (job) => {
        await this.process(type, job)
      }, {connection, concurrency})

In version 3.15.8, this throws an error Error: concurrency must be a number greater than 0, despite passing in a non 0 value for the concurrency.

Have there been any breaking changes introduced in this API?
The docs seem to indicate it's still the same: https://docs.bullmq.io/guide/workers/concurrency

How to reproduce.

See code example in description above

Relevant log output

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[manast]

@adamreisnz is it possible that you are passing a string instead of a number? It is not a breaking change, more like it is detecting a potential error in your code that was not being detected before.

[andrews05]

Following up here on behalf of @adamreisnz:
Thanks @manast, turned out that was indeed the problem so should be easy for us to resolve. The issue can be closed.

[adamreisnz]

Thanks @andrews05 , and yes, as we were feeding the vars in from heroku env vars, these were coming in as a string.

Appreciate that you may consider this a potential application error @manast, however, if previously a value of '1' was considered valid input, and now it no longer is, this still constitutes a major breaking change, as the workers would not spin up anymore (not even default to a concurrency of 1).

So I would recommend for future changes of this nature to bump your major version of the package to avoid any issues.

Thanks!