Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Prefer release artifacts over building from submodules for the purposes of build container images #43

Open
jbreiding opened this issue Apr 14, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jbreiding
Copy link
Contributor

jbreiding commented Apr 14, 2022

Is your feature request related to a problem? Please describe.

This repo depends on submodules to build binaries that are already built and should be artifacts tagged as releases on the respective submodule repos.

Rather than rebuilding this repo should be downloading and extracting the tar ball to the respective container image.

Describe the solution you'd like

Replace submodules with shell script to curl and extract taking in the respective release versions as build args.

Additional context

Temporal repo already emits go-releaser artifacts with release tags.
tcl and ui-server must do the same.
I will take on the work to land those changes in the respective repos and then work to reconcile those changes into this repo.

@jbreiding jbreiding added the enhancement New feature or request label Apr 14, 2022
@jbreiding jbreiding self-assigned this Apr 14, 2022
@jbreiding jbreiding changed the title [Feature Request] FILL_TITLE_HERE [Feature Request] Prefer release artifacts over building from submodules for the purposes of build container images Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant