Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] Rust SDK add option to specify task_queue for child workflows #642

Open
c-thiel opened this issue Nov 22, 2023 · 1 comment
Open

[Feature Request] Rust SDK add option to specify task_queue for child workflows #642

c-thiel opened this issue Nov 22, 2023 · 1 comment
Labels
enhancement New feature or request Rust SDK Issues about or asking for Rust SDK release

Comments

@c-thiel
Copy link
Contributor

c-thiel commented Nov 22, 2023

Is your feature request related to a problem? Please describe.

I can't find a way to specify the task_queue for child workflows using the rust SDK

Additional context

Currently using the rust SDK a child workflow can be started like this (from the tests):
https://github.com/temporalio/sdk-core/blob/2878bab153f9593d8abbefd4c554c53f4b0fa958/core/src/core_tests/child_workflows.rs#L80C1-L98C72

Right now the ChildWorkflowOptions is missing the task_queue parameter.
As a result, when converting it to a StartChildWorkflowExecution command here, the task_queue is filled via Default.

I can create a PR. It would be great if somebody could briefly confirm that extending ChildWorkflowOptions and then the transformation to the command is the way to go!
@c-thiel c-thiel added the enhancement New feature or request label Nov 22, 2023
@Sushisource
Copy link
Member

@c-thiel That is the way to go - feel free to open a PR. Thanks.

@Sushisource Sushisource added the Rust SDK Issues about or asking for Rust SDK release label Nov 23, 2023
@c-thiel c-thiel mentioned this issue Nov 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Rust SDK Issues about or asking for Rust SDK release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Sushisource @c-thiel