Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Core should not keep retrying local activities indefinitely after worker shutdown has been requested #709

Open
bergundy opened this issue Mar 25, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@bergundy
Copy link
Member

Today Core automatically retries local activities after worker shutdown has been requested.
In addition to that all local activities are cancelled after the shutdown grace period has expired.

The combination of the two can very easily put the worker in a loop where activity attempts are being exhausted very fast and prevent the worker from shutting down.

It would be better to stop scheduling activity retries after worker shutdown has been requested.
Ideally the progress wouldn't be lost and Core would store progress information in a marker but initially failing the workflow task and letting the server schedule a retry on the next available worker is preferable to the current behavior.

@bergundy bergundy added the bug Something isn't working label Mar 25, 2024
@bergundy bergundy changed the title [Bug] Core should not keep retrying local activities indefinitely after worker shutdown has been requested. [Bug] Core should not keep retrying local activities indefinitely after worker shutdown has been requested Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant