Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't initialize Firebase for tests #920

Open
bherbst opened this issue May 23, 2019 · 0 comments
Open

Don't initialize Firebase for tests #920

bherbst opened this issue May 23, 2019 · 0 comments

Comments

@bherbst
Copy link
Contributor

bherbst commented May 23, 2019

One somewhat common source of test flakiness that I have observed is Firebase failing to initialize in our unit test, usually with a message like this:

java.util.concurrent.RejectedExecutionException: Task java.util.concurrent.FutureTask@3a918bde[Not completed, task = java.util.concurrent.Executors$RunnableAdapter@2975e4ef[Wrapped task = com.google.android.gms.internal.crash.zzf@46f1dde8]] rejected from java.util.concurrent.ThreadPoolExecutor@a5db1dd[Terminated, pool size = 0, active threads = 0, queued tasks = 0, completed tasks = 1]

Really, we shouldn't be initializing Firebase and using it in our tests anyway.

The vast majority of this dependency comes from our TbaLogger, which logs everything to Firebase. My proposal is that we switch to Timber and use a different Tree for tests that doesn't report to Firebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant