Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defineChain not overrided the value from thirdweb chainlist #3022

Closed
iamcryptofennec opened this issue May 14, 2024 · 3 comments · Fixed by #3027
Closed

defineChain not overrided the value from thirdweb chainlist #3022

iamcryptofennec opened this issue May 14, 2024 · 3 comments · Fixed by #3027
Assignees
Labels
bug Something isn't working

Comments

@iamcryptofennec
Copy link

My defineChain config
image

My Popup

  • Icon doesn't be changed
  • Explorers url not included (undefined)
    image
    image

It looks like to take a data from thirdweb.com/chainlist

Maybe I misunderstood about defineChain concept. But should it able to override the value?

@jnsdls
Copy link
Member

jnsdls commented May 14, 2024

@iamcryptofennec it should, but you are correct it currently does not in this part of the UI. This is a bug and we should be able to fix it relatively quickly.

@jnsdls jnsdls added the bug Something isn't working label May 14, 2024
@gregfromstl gregfromstl self-assigned this May 14, 2024
@gregfromstl
Copy link
Member

@iamcryptofennec could you try this again on thirdweb@nightly? Should be fixed now

@iamcryptofennec
Copy link
Author

@iamcryptofennec could you try this again on thirdweb@nightly? Should be fixed now

Yes, it works well on 5.20.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants