Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop bower support and remove compiled code from source control #23

Open
timwis opened this issue May 30, 2017 · 0 comments
Open

Drop bower support and remove compiled code from source control #23

timwis opened this issue May 30, 2017 · 0 comments

Comments

@timwis
Copy link
Owner

timwis commented May 30, 2017

Including dist makes it inconvenient to submit pull requests -- the submitter isn't sure whether to include it in the PR, and the author has no insight into whether the new compiled file accurately reflects the latest source code. I think instead we'd run the build command during npm publish. The gh-pages branch also needs it for the demos, so we could use travis to compile and push from the master branch to gh-pages.

This would probably mean bower no longer works, though, as there's no compiled version sitting on github. Do people still use bower? Any other advantages to having the built file in source control?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant