Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to utilise chroma's domain setting? #25

Open
landworth opened this issue Oct 7, 2017 · 3 comments
Open

Possible to utilise chroma's domain setting? #25

landworth opened this issue Oct 7, 2017 · 3 comments

Comments

@landworth
Copy link

Firstly, I love your choropleth plugin. It's working great, except the color scale setting isn't quite precise enough for what I need.

I've tried using chroma's domain setting (https://gka.github.io/chroma.js/#scale-domain) to be more specific about how it sets colors, but it doesn't seem to pass through your plugin.

Is it possible to enhance the plugin to utilize this setting?

Thanks in advance

@timwis
Copy link
Owner

timwis commented Oct 9, 2017

Thanks! That sounds like a reasonable addition for an optional feature. Would you be interested in submitting a pull request that adds it?

@landworth
Copy link
Author

Thanks Tim.. I'm up for submitting a pull request, but I'll be entirely honest and say I'm a newbie with Git. Any chance you can walk me through the process or point me in the right direction? Thanks!

@timwis
Copy link
Owner

timwis commented Oct 9, 2017

Sure. The easiest way is to make the changes in GitHub's web editor:
https://help.github.com/articles/editing-files-in-another-user-s-repository/

The more proper way to do it is to fork this repository, then clone your forked repository onto your computer, modify the files there, commit them and push them back to your forked repository, then click the "new pull request" button on your forked repository on github.com to propose your changes be merged into the parent/upstream repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants