Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gist to be passed to editor #165

Open
marks opened this issue Jan 24, 2016 · 5 comments
Open

Allow gist to be passed to editor #165

marks opened this issue Jan 24, 2016 · 5 comments

Comments

@marks
Copy link
Collaborator

marks commented Jan 24, 2016

No description provided.

marks pushed a commit to marks/vizwit that referenced this issue Jan 24, 2016
@marks
Copy link
Collaborator Author

marks commented Jan 24, 2016

@timwis
Copy link
Owner

timwis commented Jan 24, 2016

Heh, I actually had this working but realized that vizwit-editor.js looked nearly identical to vizwit-loader.js. The logical question was, "well why not combine them?" perhaps using an &editor=true querystring to enable the editor. Definitely possible, but then every vizwit page would be running with ace and split.js unnecessarily.

The alternative, of course, is to have some redundancy between those two files.

One of the coolest benefits of this feature would be to add an 'edit' button to every vizwit page.

@marks
Copy link
Collaborator Author

marks commented Jan 24, 2016

Heh, looks like I took the easy route, as intended, and created "some redundancy between those two files."

@marks
Copy link
Collaborator Author

marks commented Jan 24, 2016

I'll let you make the tough decisions.. let me know if you want me to send a PR. This suits my needs for now!

@marks
Copy link
Collaborator Author

marks commented Jan 24, 2016

One more thought - you could keep them separate for simplicity and an "edit" button could simply link to the editor view with the gist ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants