Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New card: full details of a single record #173

Open
marks opened this issue Apr 9, 2016 · 7 comments
Open

New card: full details of a single record #173

marks opened this issue Apr 9, 2016 · 7 comments

Comments

@marks
Copy link
Collaborator

marks commented Apr 9, 2016

I would like to support a use case where a user wants to see all the details of a record (a crime, for example). In such a case, a table is not optimal as you have to scroll left and right to see all

This view would be served the same data as the current table component and would just be a styling change, I think

In other words: be able to have a card that lets one page through one record at a time, with a style similar to a fly out on a map, as shown below from https://data.phila.gov/dataset/Bicycle-Thefts/uxgh-g393

xyc0pr43ln

@timwis
Copy link
Owner

timwis commented Apr 9, 2016

That's a cool idea @marks! Just spitballing here but would it make sense to be part of the table view? Like a "view" icon on each row that expands the row or shows the contents in a popover? I just imagine it would enable you to fly around the records more easily by paginating / filtering the other charts as you would the table.

@marks
Copy link
Collaborator Author

marks commented Apr 9, 2016

@timwis - that's probably the right way to go.. I started fumbling around to combine the callout.js and table.js cards to do this somehow when in fact DataTables seems to already have this feature: https://datatables.net/examples/server_side/row_details.html

marks pushed a commit to marks/vizwit that referenced this issue Apr 9, 2016
@marks
Copy link
Collaborator Author

marks commented Apr 9, 2016

I hacked this together and put it live at http://marks.github.io/vizwit/?gist=a304ce8fac9c14dfbf16 . Demo below.

@timwis something you'd be interested in master? Think it should be behind a feature toggle or not? I know the code needs to be cleaned up a bit but the this.table/table thing I dont fully understand if you have time to look.

kmdui4esib

@timwis
Copy link
Owner

timwis commented Apr 11, 2016

@marks that's awesome! Nice work!! I think that's a great candidate for master. Can't seem to find the code you wrote for it though - can you get a PR going?

@marks
Copy link
Collaborator Author

marks commented Apr 11, 2016

@timwis totally - on by default or opt-in?

@timwis
Copy link
Owner

timwis commented Apr 11, 2016

Hm.. I would say "always on" but I imagine for datasets with only a few columns, it would be pointless/distracting to have it there, so there should be an option to disable it. And negative-config-settings (ie. disableRowDetails: true as opposed to rowDetails: false) seem counter-intuitive. So perhaps a config setting makes the most sense. What do you think?

@marks
Copy link
Collaborator Author

marks commented Apr 11, 2016

Sounds like you're voting for opt-in which is totally cool with me. I will clean up my feature branch and update this thread with a PR that we can both work off of in the next few days

marks pushed a commit to marks/vizwit that referenced this issue Apr 11, 2016
marks pushed a commit to marks/vizwit that referenced this issue Apr 11, 2016
marks pushed a commit to marks/vizwit that referenced this issue Apr 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants