Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor API key config organization #1332

Open
csssuf opened this issue Jul 20, 2016 · 4 comments
Open

Refactor API key config organization #1332

csssuf opened this issue Jul 20, 2016 · 4 comments

Comments

@csssuf
Copy link
Member

csssuf commented Jul 20, 2016

API key configuration is kind of a mess. I think there's a better way to organize them, but I'm not sure what that is. We should figure that out and implement it.

@csssuf
Copy link
Member Author

csssuf commented Jul 20, 2016

Most of my motivation behind this is for API keys only needed by specific commands. Those definitely don't need to be in the core config, and we should look into creating more generalized per-command configuration apart from API keys.

@pefoley2
Copy link
Member

I mean, I feel like having a central place for bot-specific configuration is a good thing.
I guess we could add something like groups.cfg, but I'm not really sure how that would improve anything over the status quo.
I feel like it's easier to add keys to a central file, rather than having to go dig through a config directory or something.
That said, I'm open to suggestions.

@csssuf
Copy link
Member Author

csssuf commented Jul 20, 2016

Yeah, thinking about it more I think it makes more sense to keep everything in one config file but reorganize how it's laid out and how it gets passed to commands.

@pefoley2
Copy link
Member

Sure, the current system more or less grew organically and could do w/ some cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants