Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark mode #544

Open
ranile opened this issue Jan 29, 2021 · 6 comments
Open

Add dark mode #544

ranile opened this issue Jan 29, 2021 · 6 comments

Comments

@ranile
Copy link

ranile commented Jan 29, 2021

The website should have a dark mode that based on prefers-color-scheme media query.

There's no built-in support for dark mode in Bulma (jgthms/bulma#2342) so I imagine it has be implemented by manually tweaking the color values.

@ghost
Copy link

ghost commented Aug 8, 2021

There is definitely demand for this feature. I am not at all a web designer, I'm afraid, but I want to express support for it. Purely from the perspective of an end user, your proposal seems reasonable. I really like the way mdbook handles things, though I have no idea if that meets the requirements you've listed.

@Darksonn
Copy link
Contributor

Darksonn commented Aug 8, 2021

If you make a reasonable implementation of dark mode, I will be happy to merge it.

@adsick
Copy link

adsick commented Nov 9, 2021

want it too, strange to see it's absence...

@stanwolverine
Copy link
Contributor

Hello, I have been working on this issue. Choosing colours for a dark theme has been a very difficult task for me. I want feedback about the chosen colour palette from you guys.

Screenshot 2023-04-07 at 11 20 47 PM

Screenshot 2023-04-07 at 11 20 58 PM

@Jhraumg
Copy link

Jhraumg commented Apr 16, 2023

th

Hello, I have been working on this issue. Choosing colours for a dark theme has been a very difficult task for me. I want feedback about the chosen colour palette from you guys.

Screenshot 2023-04-07 at 11 20 47 PM Screenshot 2023-04-07 at 11 20 58 PM

This looks nice ! Somewhat brighter and warmer than Github dark mode, but really readable.
I tried real quick bulma-prefers-dark, mentionned in Bulma issue, to compare it to your theme, but it does not work "as is" :
image

Do you have some code (shell, toml & rust) screenshots as well ?

@stanwolverine
Copy link
Contributor

@Jhraumg Thanks for the feedback. I also tried some quick solutions to make dark theme work nicely with bulma but they didn't work, so I had to do it manually.

I don't have any more screenshots right now. I will finish this work in some days and then you will be able to preview it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants