Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Add support for native style emoji #5

Open
elronalds opened this issue Jan 31, 2016 · 8 comments
Open

Add support for native style emoji #5

elronalds opened this issue Jan 31, 2016 · 8 comments

Comments

@elronalds
Copy link

It would be awesome to have support for the different emoji sprite sheets available at https://github.com/iamcal/emoji-data

They support some of the native style emoji images as well as Twitter and emojione.

@tommoor
Copy link
Owner

tommoor commented Jan 31, 2016

It would be a great feature! The only downside that I see from using a datasource like that is it will always be a little out of date and we're dependent on iamcal to keep it so.

@elronalds
Copy link
Author

I think there is build scripts in the iamcal/emoji-data project that can help with the updating - not sure how automated it is yet. I'll take a look at it later. They aren't using the Q1 2016 emojione update yet. I believe they already have the latest Apple emoji added though.

@elronalds
Copy link
Author

I just checked into this and the build scripts are fairly straight forward to update these if they need to be done ourself in a fork. I ran through the update for the emojione Q1 2016 update without issues. There is already a pending push request for that update.

@elronalds
Copy link
Author

I have forked the emoji-data project at https://github.com/elronalds/emoji-data and updated it to the emojione 2016 Q1 update and submitted a PR to iamcal. I'm happy to maintain and keep this up-to-date.

I think the first step for this would be adding support for the emoji-data sprite files. Let me know what you think @tommoor

@natenorberg
Copy link

Would there be anything wrong with using the native emojis by using shortnameToUnicode instead of shortnameToImage? Then you could just pass in a useNative prop into emojiPicker?

@tommoor
Copy link
Owner

tommoor commented Apr 29, 2016

Hey Nate,

You could do this although platform support is inconsistent - if you know
that it will only be used on a Mac for example then this might be a nice
option to have :)

@natenorberg
Copy link

That makes sense. Should I open a pull request for that?

@tommoor
Copy link
Owner

tommoor commented Apr 29, 2016

Sure, go ahead!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants