Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

Idea: Separate base/layout styles from "theme" styles #51

Open
ahutchings opened this issue Feb 2, 2017 · 1 comment
Open

Idea: Separate base/layout styles from "theme" styles #51

ahutchings opened this issue Feb 2, 2017 · 1 comment

Comments

@ahutchings
Copy link
Contributor

ahutchings commented Feb 2, 2017

I'm using the emoji picker in an application that supports multiple themes. I'm currently pulling in the emojione-picker css file and layering in overrides for each theme. It would be nice if certain elements, such as the search input, could inherit my generic element styles from my app theme without needing the overrides.

One option is to separate the base/layout styles into a standalone file, and put all aesthetic properties such as colors into a separate "default-theme.css" file. This would give users the flexibility to pull in the default theme file only if they want it.

Thoughts?

@tommoor
Copy link
Owner

tommoor commented Feb 16, 2017

I think this is a good idea, although It's a shame they'd need to pull in an additional css file. Perhaps we could have a theme prop that could be set to a falsey value?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants