Support #if and #ifdef in if statements #202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a sizable state count increase, and I don't think I really want to support this use case - this just opens the door for many other edge cases with preproc defines as well. Tree-sitter is just not going to handle every possible usage of macros and/or preproc defines well |
|
Thank you for your feedback. Is there any state count where you would accept this? I got the state count down to 2594 and all of the tests (including the ones I added) pass. |
|
What's the large state count? But again, this still sets a precedence I don't like anyways, and might be even more harmful for C++ since that would need to be updated with these changes afterwards. |
#define LANGUAGE_VERSION 14
#define STATE_COUNT 2594
#define LARGE_STATE_COUNT 693
#define SYMBOL_COUNT 352
#define ALIAS_COUNT 3
#define TOKEN_COUNT 155
#define EXTERNAL_TOKEN_COUNT 0
#define FIELD_COUNT 39
#define MAX_ALIAS_SEQUENCE_LENGTH 9
#define PRODUCTION_ID_COUNT 132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #76
I was not able to add more than
$.preproc_if_in_if_statementand$.preproc_ifdef_in_if_statementto_else_clause_preproc. I got some conflicts. I am not very experienced in writing tree-sitter grammars.