Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRI-2209] CLI init: If there's no include in the tsconfig.ts file then don't add trigger.config.ts to it (v3) #1017

Open
matt-aitken opened this issue Apr 10, 2024 · 0 comments · May be fixed by #1105
Labels
v3 Only impacts version 3 projects

Comments

@matt-aitken
Copy link
Member

matt-aitken commented Apr 10, 2024

If you don't have include in your tsconfig.json TypeScript includes all TypeScript files inside the project directory.

Currently our CLI adds trigger.config.ts to include always.

{
  "extends": "@tsconfig/node18/tsconfig.json",
  "compilerOptions": {
    "module": "esnext",
    "moduleResolution": "node",
    "resolveJsonModule": true,
    "jsx": "preserve",
    "noUncheckedIndexedAccess": true
  },
  "include": ["trigger.config.ts"] // <= this is the newly added line
}

This breaks TypeScript for every other files because now they don't match anymore.

Fix

If there's no existing include then don't add trigger.config.ts.

TRI-2209

@matt-aitken matt-aitken added the v3 Only impacts version 3 projects label Apr 10, 2024
@matt-aitken matt-aitken changed the title CLI init: If there's no include in the tsconfig.ts file then don't add trigger.config.ts to it (v3) [TRI-2209] CLI init: If there's no include in the tsconfig.ts file then don't add trigger.config.ts to it (v3) Apr 10, 2024
@alexandredev3 alexandredev3 linked a pull request May 16, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 Only impacts version 3 projects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant