Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRI-2048] Better handle fetch throwing errors in our ApiClient #935

Open
ericallam opened this issue Mar 9, 2024 · 0 comments
Open

[TRI-2048] Better handle fetch throwing errors in our ApiClient #935

ericallam opened this issue Mar 9, 2024 · 0 comments

Comments

@ericallam
Copy link
Member

ericallam commented Mar 9, 2024

As you can see in the code below, we aren't handling any thrown errors by fetch:

async function zodfetch<TResponseSchema extends z.ZodTypeAny, TOptional extends boolean = false>(

This can lead to issues when the fetch times out and throws an error. We should fix this and also investigate which other errors can be thrown and handle those with retries (if it makes sense).

TRI-2048

@ericallam ericallam changed the title Better handle fetch throwing errors in our ApiClient [TRI-2048] Better handle fetch throwing errors in our ApiClient Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant