Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

2 Step Authentification = Blank Page #39

Open
p-j opened this issue Feb 19, 2016 · 43 comments
Open

2 Step Authentification = Blank Page #39

p-j opened this issue Feb 19, 2016 · 43 comments

Comments

@p-j
Copy link

p-j commented Feb 19, 2016

Hi

I just tried to run your app on my Ubuntu. It launches fine and I can enter email and password but when comes the time to enter the code I receive by SMS, the page is completely white, even though the DOM is present (using the developer tool I can see it's present).

Any advice on what I could do (beside using a different kind of auth) ?

@twolfson
Copy link
Owner

I don't have any ideas if there isn't anything in the terminal/console about it =(

I will take a look by the end of next weekend

@twolfson
Copy link
Owner

Took a look at reproducing this issue. Unfortunately, I was unable to reproduce. However, it reminds me of an issue we had in #29 which was resolved via an electron upgrade.

However, it looks like we are on the latest version of electron =( (~0.36.3 === 0.36.x, latest is 0.36.8)

https://github.com/atom/electron/releases

For our sanity, can you confirm the current version of electron via npm ls electron-prebuilt?

@p-j
Copy link
Author

p-j commented Feb 21, 2016

Just reinstalled it and got

~/.nvm/versions/node/v5.6.0/lib
└─┬ google-music-electron@2.9.0 
  └─┬ electron-prebuilt@0.36.8
    └─┬ electron-download@1.4.1
      └─┬ nugget@1.6.2
        ├─┬ pretty-bytes@1.0.4
        │ └─┬ meow@3.7.0
        │   └─┬ decamelize@1.1.2
        │     └── escape-string-regexp@1.0.5 
        └─┬ request@2.69.0
          ├─┬ har-validator@2.0.6
          │ └─┬ chalk@1.1.1
          │   ├─┬ ansi-styles@2.2.0 
          │   │ └── color-convert@1.0.0 
          │   └── strip-ansi@3.0.1 
          └─┬ http-signature@1.1.1
            └─┬ sshpk@1.7.4
              └── tweetnacl@0.14.0 

Tried to sign in, same problem.

Running Node v5.6.0 and npm 3.6.0 on Ubuntu 14.04.4

@twolfson
Copy link
Owner

Are there any errors in the Developer Tools console or stderr?

@urandom
Copy link

urandom commented Mar 3, 2016

I'm only getting this error in the dev console, though it appears in the previous screen (the one with the login button):
Failed to find navigation button
/usr/lib/node_modules/google-music-electron/lib/browser.js:61

@twolfson
Copy link
Owner

twolfson commented Mar 3, 2016

That is a tolerable error to occur before login as long as the page is still rendering =/

@urandom Are you experiencing the same white screen issue and are using 2 step auth?

@p-j If you reload the page after logging in (View -> Reload), does the page still show a white screen?

@urandom
Copy link

urandom commented Mar 3, 2016

@twolfson
Yes, I'm using two step, and I get a white screen after I log in (or directly, when I was still logged in). Incidentally, on a completely different computer, but with the same account, it works just fine. Could be because it might still be on an older checkout.

@twolfson
Copy link
Owner

twolfson commented Mar 3, 2016

What OS's are the 2 computers running?

@urandom
Copy link

urandom commented Mar 3, 2016

The exact same OS, arch linux

@twolfson
Copy link
Owner

twolfson commented Mar 3, 2016

Weird, it must be the electron version. Can you find out what versions of google-music-electron and electron they are running? (Help -> About google-music-electron)

@urandom
Copy link

urandom commented Mar 7, 2016

Where things still work, the about screen prints out:
Version: 2.6.0
Electron version: 0.34.5
Node.js version: 4.1.1
Chromium version: 45.0.2454.85

@urandom
Copy link

urandom commented Mar 7, 2016

It also works (on the working computer) with the system electron instance:
Version: 2.6.0
Electron version: 0.36.7
Node.js version: 5.1.1
Chromium version: 47.0.2526.110

@twolfson
Copy link
Owner

twolfson commented Mar 7, 2016

I don't follow. What were your install processes for both of those versions?

@urandom
Copy link

urandom commented Mar 7, 2016

The first comment is the regular usage (using sudo npm install -g ...). I also have electron installed separately (sudo pacman -S electron) for my own testing. So I just ran gme with 'electron /usr/lib/node_modules/go...'

@twolfson
Copy link
Owner

twolfson commented Mar 7, 2016

Ah, k. Can you try installing a downgraded version of google-music-electron on the non-working computer?

npm install -g google-music-electron@2.6.0

@urandom
Copy link

urandom commented Mar 7, 2016

I'll try it tonight. I'll also try with the system electron version, since I haven't tested that

@twolfson
Copy link
Owner

twolfson commented Mar 7, 2016

Fwiw, electron@0.35.0 deprecated a lot of modules in favor of a single electron module. We patched those deprecation warnings in google-music-electron@2.9.0

https://github.com/atom/electron/releases/tag/v0.35.0

2.8.0...2.9.0

@urandom
Copy link

urandom commented Mar 7, 2016

On the non-working computer, it didn't work with the system electron instance, and it didn't work with v2.9.0

@twolfson
Copy link
Owner

twolfson commented Mar 7, 2016

What about with a globally installed 2.6.0?

npm install -g google-music-electron@2.6.0

@urandom
Copy link

urandom commented Mar 8, 2016

I only do globally installed. I made sure to remove every trace of gme beforehand (cache, config, the actual files)

@twolfson
Copy link
Owner

twolfson commented Mar 8, 2016

Right but google-music-electron ships with a prebuilt version of Electron. In your comment you said you used a system electron instance =/

@urandom
Copy link

urandom commented Mar 8, 2016

I used both the system electron instance and the prebuilt one. With the system one, it was to make sure that, given identical electron versions, it would work like the one on the working system. It turned out not to be the case, since I still got the blank screen.

@twolfson
Copy link
Owner

twolfson commented Mar 8, 2016

Ah, k. It sounds like we have an OS specific crash like in #29 which means we should report it. First, we have to verify that the problem is definitively Electron/Google Music. Can you follow the steps in this gist on the failing machine?

https://gist.github.com/twolfson/5df0d2a9653be92dbec0#file-readme-md

@p-j
Copy link
Author

p-j commented Mar 8, 2016

I tried also 2.9.0 and 2.6.0
I'm running Ubuntu 14.04.4
Both are failing at the same stage.
It's potentially good to add that the welcome screen is in french, the connexion screen is in english and my google account is in english. I don't know if that can trigger anything weird on the way...

In the console I only get a Failed to initialize GMusic. Trying again in 1 second from lib/browser.js:82
I also have right from the start a Failed to find navigation button from lib/browser.js:61

@p-j
Copy link
Author

p-j commented Mar 8, 2016

Also, the DOM is present, but nothing is rendered.

@p-j
Copy link
Author

p-j commented Mar 8, 2016

When I run the gist, I have the connexion screen, I can proceed to submit email address and password, but it fails at the same point when I need to enter the 2-step code I received by text message.

@p-j
Copy link
Author

p-j commented Mar 8, 2016

Also, when I start it I have this

(electron) companyName is now a required option to crashReporter.start
Starting application with process.versions: { http_parser: '2.6.0',
  node: '5.1.1',
  v8: '4.7.80.27',
  uv: '1.7.5',
  zlib: '1.2.8',
  ares: '1.10.1-DEV',
  modules: '47',
  openssl: '1.0.2e',
  electron: '0.36.10',
  'atom-shell': '0.36.10',
  chrome: '47.0.2526.110' }

@twolfson
Copy link
Owner

twolfson commented Mar 8, 2016

While starting to submit a new issue on Electron, I found this issue:

electron/electron#4513

Due to @urandom having this problem machine specifically and me never being able to reproduce on Linux Mint, I have a feeling it's a distribution specific problem.

@urandom Can you compare system level dependencies between the 2 machines? I know for Debian packages this is via dpkg --list but I'm not sure about Arch.

@MarshallOfSound
Copy link

Just adding my 2 cents here, for some reason the login screen glitches with certain GPU drivers (who knows...)

If you start the electron app with --disable-gpu it works 🌵

@urandom
Copy link

urandom commented Mar 19, 2016

@MarshallOfSound
This solves the problem on an intel gpu. It also appears to only be needed for the actual 2-way auth step. Once you log in, you can start gme with gpu support, until you log out.
Since my problematic laptop also has an nvidia gpu, I ran gme through primusrun to force it to go through the nvidia one, and there I don't observe any problems.

Curious that on my working laptop the gpu is also an intel one, yes gme works despite the drivers for both being the same

@twolfson
Copy link
Owner

We should probably report this to Atom or Chromium so it can get properly fixed =/

@p-j
Copy link
Author

p-j commented Mar 21, 2016

It indeed work with the --disable-gpu flag.
As for myself, I'm running a Dell m3800 Developer Edition with the preinstalled Ubuntu 14.04.
It comes with both intel 4th Gen Integrated Graphics & an nVidia Quadro K1100M but I'm not using it since battery is more important to me and I don't need more than the Intel Graphics for writing code :)

In fact, its event possible the nVidia is not working at all as I've never tested it and some forum reports its not working out of the box. But it's a different story.

@urandom
Copy link

urandom commented Mar 21, 2016

seems both mine and @p-j's problematic machines have some sort of nvidia optimus or equivalent setup.

@liamdawson
Copy link

Confirming the same experience as @p-j and @urandom.

@p-j
Copy link
Author

p-j commented Aug 25, 2016

On my part I've moved to Google Play Music Desktop Player which works fine so far.

@g105b
Copy link

g105b commented Jan 17, 2017

I'm having the same issue. Ubuntu 16.04 64bit. npm version 3.5.2. node version 4.2.6. (non-configured basic install via apt install npm && npm install google-music-electron).

@twolfson
Copy link
Owner

@g105b Are you seeing any errors in the developer console? What happens when you use --disable-gpu as recommended by the other comments?

@g105b
Copy link

g105b commented Jan 18, 2017

@twolfson Sorry, nothing output in terminal once loaded, and disabling the gpu doesn't do anything either. I run other electron apps successfully, such as Slack, Nylas and now Google Play Music Desktop Player.

@twolfson
Copy link
Owner

Ah, not the terminal -- I meant Chrome Dev Tools' console (accessed via View -> Developer -> Toggle Developer Tools). That being said, it's been a while since we last upgraded Electron so I'll give that a whirl

@twolfson
Copy link
Owner

Hmm, I tried upgrading to both Electron@1.3.x and @1.4.x but there seems to be something that prevents the processing from closing once I start playing music. It won't even halt on a SIGINT; I need to SIGKILL it =(

It's not specific to our repo as I reproduced the issue by launching a vanilla Electron application and navigating via window.location

I don't have time to look into this further tonight but I guess the Electron update is on ice until that's resolved =/

@twolfson
Copy link
Owner

Decided to keep on digging and making progress, going to make a separate issue to prevent diverging from the main topic (#44)

@g105b
Copy link

g105b commented Jan 18, 2017

I'll try and get some time to look at the code at some point soon.

@twolfson
Copy link
Owner

We stalled out on Electron's GitHub issues with respect to #44 and blockers for our upgrade. We decided to finally implement a non-ideal workaround and released that today. We're now running electron@1.6.2 as of 2.15.0.

Can someone try this out and let us know if 2 factor auth yields a blank page?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants