Skip to content
This repository has been archived by the owner on Dec 4, 2020. It is now read-only.

Toolbar Icon Improvements #7

Open
JTarasovic opened this issue Jul 10, 2015 · 3 comments · May be fixed by #28
Open

Toolbar Icon Improvements #7

JTarasovic opened this issue Jul 10, 2015 · 3 comments · May be fixed by #28

Comments

@JTarasovic
Copy link

On OSX with the dark toolbar, the toolbar icon looks like this: toolbar.

I think the answer is to use Template Images. I tried just appending template to the pngs in /lib/assets/* as well as within app-tray.js. It worked but the icon is probably too large with a HiDPI monitor and the inverted play and paused were weird.

I'm getting ready to move to a different country but I can try to mess with it a bit this weekend if I get a couple of hours.

@JTarasovic
Copy link
Author

Also, at least on the El Capitan preview, it just calls itself Electron and uses the standard dock image.

@twolfson
Copy link
Owner

Oh weird, I had no idea OS X had a dark toolbar. I am open to both template images (had no idea that was a thing) and generating a set of images with white headphones.

With respect to the dock image, that is something that is known (at least on Linux it is the default window icon) but the process text typically changes to the song being played. In any case, I am open to supporting this as well.

@akszydelko
Copy link

I have the same problem with too big image, but I don't have a dark theme so it's easier to see the problem:
screen shot 2015-10-31 at 18 47 51

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants