Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laplaya XML Sanitization #1

Open
jhenkens opened this issue Aug 16, 2014 · 3 comments
Open

Laplaya XML Sanitization #1

jhenkens opened this issue Aug 16, 2014 · 3 comments

Comments

@jhenkens
Copy link
Contributor

I really, really wish we used a standard XML writer for LaPlaya.

Instead, by constructing it by hand, we are left with broken XML all the time. Two cases where I have hit this already

  1. attributes that were touching test="asfda"helloworld="abcdf". This isn't allowed.
  2. Escaping didn't work for names, a few other places. I tried to fix it. I probably failed. This is why we don't do XML by hand. IT IS REALLY, REALLY, REALLLLLY hard. Let other people do it. We should really rewrite the system to use an XML reader and writer.

See c4668e0
@jhenkens
Copy link
Contributor Author

@rtwaltman @CoheedAC

@jhenkens
Copy link
Contributor Author

I tried to fix 2. I have no idea what causes 1. Right now I have to hackily fix these server side, which really isn't okay..

See c4668e0

@jhenkens
Copy link
Contributor Author

See ucsb-cs-education/octopi-webapp@66181fe for my octopi fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhenkens