Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most hook promise rejections are unhandled #754

Open
haines opened this issue Dec 6, 2023 · 0 comments
Open

Most hook promise rejections are unhandled #754

haines opened this issue Dec 6, 2023 · 0 comments
Assignees
@janthurau
Labels
bug Something isn't working

Comments

@haines
Copy link
Contributor

haines commented Dec 6, 2023

Description
Most of the hook invocations are not guarded with .catch() or try-await-catch, so promise rejections are unhandled. This causes a server crash by default.

Steps to reproduce the bug
Steps to reproduce the behavior:

  1. Return a rejected promise from a hook e.g. onStoreDocument
  2. Server process crashes due to unhandled rejection

Expected behavior
Errors should be handled appropriately.
@haines haines added the bug Something isn't working label Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janthurau janthurau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haines @janthurau