Fix ordered list start attribute name
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacksleight
changed the title
order attr to startstart attribute name
|
+1 |
|
+1 Running into this issue also within Statamic editing, especially lists. Would be great to see a fix |
|
Can we get this merged by any chance I have just noticed I opened an issue about this.... Otherwise will need to fork and merge in which is not something I want to be doing/maintaining... Why is this so quiet? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiptap stores an ordered lists start attribute as
start(which is the correct attribute name), but this package is looking for anorderattribute instead.This PR changes it to
startso that data created with Tiptap renders correctly in Tiptap PHP.Closes #47