Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to translate on the github website when opening an external link #104

Open
Oleg-Chashko opened this issue May 4, 2021 · 7 comments
Labels

Comments

@Oleg-Chashko
Copy link

Under certain conditions, it hangs while waiting for the translation of the text.
This happens when the link is opened from the desktop.
It seems that this behavior appeared after the last update of the application.

  • Safari v.14.1 (16611.1.21.161.6)
  • Polyglot v.3.4

Example

Screen_1.mp4

Example Link
(AdguardTeam/AdguardBrowserExtension#1799 (comment))
Example ZIP
view it on GitHub.zip

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented May 4, 2021

This looks like API limit has been reached. Google Translate only lets you translate a certain number of times over a period of time.

Wait and try again later? See #55

@Oleg-Chashko
Copy link
Author

This looks like API limit has been reached. Google Translate only lets you translate a certain number of times over a period of time.

Wait and try again later? See #55

Unfortunately not, I think there is another problem here.

As an example, not one translation has been made today.
The link is open from Apple-mail, the first translation for today immediately causes a problem. And if you translate into a direct site, there is no problem. To read, I very rarely use the application. So I do not exceed the limit. And as I wrote above that I did not have this problem before.
P.S. the latest update hasn't benefited the app.

Example

Screen_2.mp4

@gingerbeardman
Copy link
Collaborator

Do you see any errors in web inspector console?

@Oleg-Chashko
Copy link
Author

Do you see any errors in web inspector console?

Screen_3.mp4

@Oleg-Chashko
Copy link
Author

Found what this problem is related to. When you run the link. The window in which you want to translate is highlighted in blue. There will be no translation! If you click on a page of the website, the translation will be done. This is due to the structure of this website. This problem was not found on other Internet sites.

Bildschirmfoto 2021-05-05 um 15 21 55

Example

Screen_4.mp4

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented May 5, 2021

Good find! Please edit/change the bug report accordingly.

@Oleg-Chashko
Copy link
Author

Oleg-Chashko commented May 5, 2021

Good find! Please edit/change the bug report accordingly.

Always happy to help!

@Oleg-Chashko Oleg-Chashko changed the title Under certain conditions, it hangs while waiting for the translation of the text Unable to translate on the github website when opening an external link May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants