Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore HTML comments #33

Open
binyamin opened this issue Dec 9, 2019 · 5 comments
Open

Ignore HTML comments #33

binyamin opened this issue Dec 9, 2019 · 5 comments

Comments

@binyamin
Copy link

binyamin commented Dec 9, 2019

I have markdown comments in my changelog to remind me of the format. This module accidentally parses it as a release. I assume this behavior is unwanted.

@ungoldman
Copy link
Owner

I don't know of anything in any markdown specs called markdown comments, are you talking about HTML comments? Like <!-- your comment here -->?

If you can provide an example of the text that that's causing an issue for you that would be very helpful.

@binyamin
Copy link
Author

binyamin commented Dec 9, 2019

I did mean HTML comments. I use them in markdown so often that I didn't realize that they weren't part of the specs.

@ungoldman
Copy link
Owner

If you can provide an example of the text that that's causing an issue for you that would be very helpful.

@binyamin
Copy link
Author

binyamin commented Dec 9, 2019

@ungoldman
Copy link
Owner

ungoldman commented Dec 9, 2019

Thank you! That makes the issue much clearer.

This parser currently has no support for ignoring single or multiline HTML comments -- ignoring single line comments would be fairly simple, while ignoring multiline comments would require a bit more thought.

You can see how the parser currently functions for handling lines in these places:

This repository is largely in maintenance mode, but a pull request to add the required functionality would be welcome.

@ungoldman ungoldman changed the title Ignore comments Ignore HTML comments Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants