Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support different line endings in changelog #35

Closed
wants to merge 1 commit into from
Closed

Support different line endings in changelog #35

wants to merge 1 commit into from

Conversation

jayxx1234
Copy link

Allow specifying line endings in options
Fallback to try to detect from contents
Fallback to current OS line endings

Fixes #34

Allow specifying line endings in options
Fallback to try to detect from contents
Fallback to current OS line endings
@jayxx1234
Copy link
Author

I added the custom line endings option so that in (unusual) cases where the changelog uses multiple line endings (and you don't want the most common one), or line endings other than CR, LF, or CRLF, you have the ability to specify it yourself (I don't see this being a likely occurrence, but it was easy enough to add)

@ungoldman
Copy link
Owner

I'm concerned to see you've rewritten all of the tests to serve this very specific use case. I'd prefer it the preexisting tests were not heavily modified to ensure that this is not a breaking change.

@jayxx1234
Copy link
Author

I'm concerned to see you've rewritten all of the tests to serve this very specific use case. I'd prefer it the preexisting tests were not heavily modified to ensure that this is not a breaking change.

The existing tests are all intact. I only changed the outer structure of the test file, so all existing tests could be performed using each format of line ending (primarily to ensure more full test coverage of the different line endings, rather than only covering a couple of cases, and having the potential to silently break in other cases). The only real difference being that each test name is now prefixed with the format of line endings used.

@rgembalik
Copy link

Any updates on the above? I would welcome this to be a part of the official release.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cross-platform issues caused by different changelog line endings
3 participants