Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make changelog requirement less strict #35

Open
ungoldman opened this issue Apr 26, 2015 · 7 comments
Open

make changelog requirement less strict #35

ungoldman opened this issue Apr 26, 2015 · 7 comments

Comments

@ungoldman
Copy link
Owner

maybe change it from an error to a warning and allow either an empty body or use https://www.npmjs.com/package/string-editor

@ungoldman
Copy link
Owner Author

switch to warnings, e.g.

Warning: Missing CHANGELOG.md
Warning: Version mismatch (package.json, CHANGELOG.md)

@jrmykolyn
Copy link
Contributor

@ungoldman 👋

Is this still active?

@ungoldman
Copy link
Owner Author

@jrmykolyn 👋

Yes! This would be a major (breaking) change, and requires a little consideration before implementing, but would be a great addition to current functionality.

My concern is avoiding breaking workflows for current users who rely on the current CLI's strictness to ensure deploys are successful.

Maybe hiding this behind a flag (like --force) would be a good (non-breaking) way to proceed for now? Open to your thoughts on this as well.

@jrmykolyn
Copy link
Contributor

@ungoldman Hey hey. Sorry about the delay in responding to this.

Happy to help out if possible, although I think I need a deeper understanding of all the moving parts before I can offer anything of value. I'll dig into the internals and get back to you ASAP.

That said, your solution sounds like a good one!

@zanedev
Copy link

zanedev commented Aug 19, 2019

Is this still a requested feature? Was thinking of implementing it bc we have a case where no changelog is necessary. Also was thinking of adding a way to auto advance the package version number and commit it so the entire process of bumping the release and releasing it can be automated.

@bcomnes
Copy link
Collaborator

bcomnes commented Aug 21, 2019

I would still like to see it. Also, it would be nice if there was a skip release option, for when you use a gh-release hook in the release nom script. Sometimes you already gh-released and just need to skip interactively.

@zanedev
Copy link

zanedev commented Aug 21, 2019

I ended up using release-it since it did everything I needed out of the box. If I free up again and have a need for a smaller release lib I'll look at it again thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants