Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pushing to Hugging Face hub branches (revisions) and tags not working #470

Open
clrt1 opened this issue May 15, 2024 · 3 comments
Open

Pushing to Hugging Face hub branches (revisions) and tags not working #470

clrt1 opened this issue May 15, 2024 · 3 comments
Labels
currently fixing Am fixing now!

Comments

@clrt1
Copy link

clrt1 commented May 15, 2024

When using the fine-tuned model's push_to_hub_merged and push_to_hub_gguf functions, the specified revision is not used and things are instead pushed to the default active branch.

Looking through the save.py code, 'd say you need to modify the upload_to_huggingface function by adding "revision" and "tags" arguments and use those in the push_to_hub and upload_file functions enclosed therein. Maybe do similarly in other places as needed.

Would be very thankful for a fix or tips if I got something wrong.
Many thanks for your work and great framework!

@danielhanchen danielhanchen added the currently fixing Am fixing now! label May 15, 2024
@danielhanchen
Copy link
Contributor

Sorry on the issue! I'll see what I can do!

@clrt1
Copy link
Author

clrt1 commented May 25, 2024

Thank you for looking into this. Also, in a related manner, the commit_messageand commit_description that are passed to the unsloth_push_to_hub_merged and unsloth_push_to_hub_gguf functions are not used. A push to Hugging Face only shows up with the commit message "(Trained with Unsloth)" even though a specific message was passed. I think this should be easy to fix (see my opening issue message). Many thanks in advance!

@danielhanchen
Copy link
Contributor

Oh so sorry this got buried - I'll recheck the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
currently fixing Am fixing now!
Projects
None yet
Development

No branches or pull requests

2 participants