You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the defaultTheme (located in ./packages/components/defaultTheme.index.js houses all the default values for theme enabled components. Instead, let's co-located a component's default theme values with the component.
We should consider:
documenting each component's theme-enabled values (Component.themeDefinition = {}) in the same way we document propTypes.
default theme values live on the component: Component.defaultThemeValues = {}
remove the existing defaultTheme directory
ensure components that should be theme-enabled actually are (looking at you Paper; to say the least)
The text was updated successfully, but these errors were encountered:
Currently, the
defaultTheme
(located in./packages/components/defaultTheme.index.js
houses all the default values for theme enabled components. Instead, let's co-located a component's default theme values with the component.We should consider:
Component.themeDefinition = {}
) in the same way we documentpropTypes
.Component.defaultThemeValues = {}
defaultTheme
directoryPaper
; to say the least)The text was updated successfully, but these errors were encountered: