Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theming #26

Open
andrew-codes opened this issue Feb 18, 2019 · 0 comments
Open

Theming #26

andrew-codes opened this issue Feb 18, 2019 · 0 comments

Comments

@andrew-codes
Copy link
Contributor

Currently, the defaultTheme (located in ./packages/components/defaultTheme.index.js houses all the default values for theme enabled components. Instead, let's co-located a component's default theme values with the component.

We should consider:

  • documenting each component's theme-enabled values (Component.themeDefinition = {}) in the same way we document propTypes.
  • default theme values live on the component: Component.defaultThemeValues = {}
  • remove the existing defaultTheme directory
  • ensure components that should be theme-enabled actually are (looking at you Paper; to say the least)
@andrew-codes andrew-codes added this to the v1.0.0 milestone Feb 19, 2019
@andrew-codes andrew-codes added this to To do in Dev Team Feb 19, 2019
@andrew-codes andrew-codes modified the milestones: v1.0.0, Consume in V1 Mar 1, 2019
@andrew-codes andrew-codes moved this from Backlog to Ready for Dev in Dev Team Apr 26, 2019
jallers added a commit that referenced this issue Jul 11, 2019
background, border radius and box shadow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev Team
  
Ready for Dev
Development

No branches or pull requests

1 participant