Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components missing name attribute #82

Open
CWSites opened this issue Jul 22, 2019 · 2 comments
Open

Components missing name attribute #82

CWSites opened this issue Jul 22, 2019 · 2 comments
Labels
invalid This doesn't seem right wontfix This will not be worked on

Comments

@CWSites
Copy link

CWSites commented Jul 22, 2019

I noticed that the name attribute wasn't being passed through on the <Switch> component, I have a feeling that this attribute was overlooked. If we are rebuilding HTML elements then we need to make sure that we aren't inadvertently stripping default syntax or behavior.

https://www.w3resource.com/html/attributes/html-name-attribute.php
@CWSites CWSites added the invalid This doesn't seem right label Jul 22, 2019
@walkerrandolphsmith
Copy link
Contributor

No we don't need name attributes on form fields because we don't expect them to be used with class form post logic.

@walkerrandolphsmith walkerrandolphsmith added the wontfix This will not be worked on label Oct 4, 2019
@CWSites
Copy link
Author

CWSites commented Oct 4, 2019

We can discuss further, but we weren't attempting to use the name attribute in order to post from a form. IIRC we were either trying to gather information from it or we were trying to differentiate it from another input component on the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
invalid This doesn't seem right wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CWSites @walkerrandolphsmith